-
Task
-
Resolution: Unresolved
-
Major
-
None
-
None
-
None
-
5
-
False
-
-
False
-
subs-swatch-thunder
-
-
-
Swatch Thunder Sprint 6, Swatch Thunder Sprint 7
Context
This issue was identified during IQE integration testing for SWATCH-175. The goal is to ensure that the "total" measurement type is filtered out from DAILY granularity TallySummary messages sent to downstream services, consistent with how HOURLY TallySummary messages already filter it out.
Problem
During IQE integration testing for SWATCH-175 (Notifications integration), we discovered that swatch-tally is filtering out "total hardware measurement types" for HOURLY TallySummary messages but not for DAILY TallySummary messages. This means that for non-PAYG products, DAILY TallySummary messages are including both "total" and "physical" measurement types.
This issue has the following impacts:
- The inclusion of the "total" measurement type in DAILY TallySummary messages is causing duplicate notifications
- The duplicate notifications occur because the "total" measurement type gets hashed into the notification ID, making the system think it's a different notification even though the data is identical
- This affects the notification service's deduplication logic
Root Cause
This appears to be a side effect from recent changes that brought over DAILY TallySummary messages. The code is updating snapshots by reference to the list of snapshots, and the "total" measurement type is being included in DAILY TallySummary messages when it shouldn't be.
Expected Behavior
- HOURLY TallySummary messages: Continue filtering out "total" measurement types (current behavior is correct)
- DAILY TallySummary messages: Should also filter out "total" measurement types
- Nightly snapshots: Keep "total" measurement types (there's a reason we don't filter them out for nightly snapshots)
Acceptance Criteria
- DAILY granularity TallySummary messages do NOT include the "total" measurement type
- HOURLY granularity TallySummary messages continue to exclude "total" measurement type (no regression)
- Nightly snapshots continue to include "total" measurement type (no regression)
- Duplicate notifications are eliminated for non-PAYG products
- Update swatch-tally Test Plan to account for this change
- Update swatch-tally automated tests in accordance with Test Plan changes
- Update swatch-utilization Test Plan to account for this change
- Update swatch-utilization automated tests in accordance with Test Plan changes
- All existing automated tests pass
- New automated tests validate that DAILY TallySummary messages exclude "total" measurement type
- Integration tests validate the fix
- blocks
-
SWATCH-4016 Deploy swatch-utilization into production
-
- Backlog
-
- incorporates
-
SWATCH-4324 Revisit the Utilization Test Plan to include changes
-
- Closed
-
- relates to
-
SWATCH-4322 Only emit HOURLY TallySummary for payg products
-
- In Progress
-