Uploaded image for project: 'OCMUI - OpenShift Cluster Manager UI'
  1. OCMUI - OpenShift Cluster Manager UI
  2. OCMUI-1602

[ROSA HCP wizard] Quota computations use wrong billing_model

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Normal Normal
    • None
    • None
    • None
    • Quality / Stability / Reliability
    • False
    • Hide

      None

      Show
      None
    • False
    • OCMUI Core Sprint 264, OCMUI Core Sprint 265

      issue in ROSA v1 and v2.

      Hypershift initializes billing_model form field to "standard" (v1) "marketplace-aws" (v2).

      We have code to correct it to "marketplace-aws" on submission but that's too late — some quota computation during wizard uses incorrect params.
      (For quota purposes, "marketplace-aws" maps to "marketplace" quota param.)

      Quotas for Classic "standard" are all unlimited (cost: 0 => Infinity).
      Quotas for HCP "marketplace" are finite, though I see high numbers for my user, so not sure if this has realistic effects.

      ROSA results from added logging in availableQuota function:

      Control plane

      billing_model is set to "marketplace-aws" in case of hosted and "standard" in case of classic.

      Multiple queries are performed just by starting ROSA wizard creation (something that could be improved), the final one is

      {"product":"ROSA","billingModel":"marketplace","resourceType":"cluster"}
      

      The problem is CreateOsdWizard does not call (react) "availableClustersFromQuota" again in case of different Classic or Hosted selection, the output from availableQuota function is Infinity in case of standard, 3013 (for the specific case tested) in case of marketplace.

      Additionally to it, ControlPlaneScreen uses hasHostedQuotaSelector, where product and billingModel is hardcoded

      This should be fixed, basically to react from ControlPlaneScreen whenever billing_model or anyother query param has changed

      Accounts and roles

      The quotaSelectors.hasManagedQuotaSelector -> quotaSelectors.availableClustersFromQuota -> availableQuota is called multiple times and billing_model is not even there as a part of the query. This has to changed

      Cluster Settings - Details & Machine Pool

      quotaSelectors.hasManagedQuotaSelector -> quotaSelectors.availableClustersFromQuota -> availableQuota still not querying with billing_model

      Networking

      No quota interaction

      Cluster roles and policies

      No quota interaction

      Cluster updates

      No quota interaction

      Review and Create

      quotaSelectors.hasManagedQuotaSelector -> quotaSelectors.availableClustersFromQuota -> availableQuota still not querying with billing_model

        1. add_machine_pool.png
          add_machine_pool.png
          128 kB
        2. marketplace_ccs_no_quota.png
          marketplace_ccs_no_quota.png
          356 kB
        3. no_quota_day1.png
          no_quota_day1.png
          144 kB
        4. no_quota.png
          no_quota.png
          26 kB
        5. OCMUI-1602.patch
          11 kB
        6. Screenshot 2025-01-22 at 11.35.21 AM.png
          Screenshot 2025-01-22 at 11.35.21 AM.png
          547 kB

              emingora Enrique Mingorance Cano
              bpaskinc@redhat.com Beni Paskin-Cherniavsky (Inactive)
              LAKSHMI SHIVANTHI AMARACHINTHA LAKSHMI SHIVANTHI AMARACHINTHA
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Created:
                Updated:
                Resolved: