-
Bug
-
Resolution: Done
-
Normal
-
None
-
None
-
None
-
Quality / Stability / Reliability
-
False
-
-
False
-
-
-
OCMUI Core Sprint 264, OCMUI Core Sprint 265
issue in ROSA v1 and v2.
Hypershift initializes billing_model form field to "standard" (v1) "marketplace-aws" (v2).
We have code to correct it to "marketplace-aws" on submission but that's too late — some quota computation during wizard uses incorrect params.
(For quota purposes, "marketplace-aws" maps to "marketplace" quota param.)
Quotas for Classic "standard" are all unlimited (cost: 0 => Infinity).
Quotas for HCP "marketplace" are finite, though I see high numbers for my user, so not sure if this has realistic effects.
ROSA results from added logging in availableQuota function:
Control plane
billing_model is set to "marketplace-aws" in case of hosted and "standard" in case of classic.
Multiple queries are performed just by starting ROSA wizard creation (something that could be improved), the final one is
{"product":"ROSA","billingModel":"marketplace","resourceType":"cluster"}
The problem is CreateOsdWizard does not call (react) "availableClustersFromQuota" again in case of different Classic or Hosted selection, the output from availableQuota function is Infinity in case of standard, 3013 (for the specific case tested) in case of marketplace.
Additionally to it, ControlPlaneScreen uses hasHostedQuotaSelector, where product and billingModel is hardcoded
This should be fixed, basically to react from ControlPlaneScreen whenever billing_model or anyother query param has changed
Accounts and roles 
The quotaSelectors.hasManagedQuotaSelector -> quotaSelectors.availableClustersFromQuota -> availableQuota is called multiple times and billing_model is not even there as a part of the query. This has to changed
Cluster Settings - Details & Machine Pool 
quotaSelectors.hasManagedQuotaSelector -> quotaSelectors.availableClustersFromQuota -> availableQuota still not querying with billing_model
Networking
No quota interaction
Cluster roles and policies
No quota interaction
Cluster updates
No quota interaction
Review and Create 
quotaSelectors.hasManagedQuotaSelector -> quotaSelectors.availableClustersFromQuota -> availableQuota still not querying with billing_model
- is depended on by
-
OCMUI-888 [ROSA wizard] safeties for Machine Pool instance-type selection
-
- Closed
-
- relates to
-
OCMUI-976 [OCM Wizard] Compute node count is wrong after change subscription type in creation wizard
-
- Closed
-
-
OCMUI-911 [OSD Wizard, Spike] Is wizard OSDTrial / OSD / Marketplace choice ignored for quota checks?
-
- Closed
-
- mentioned on