Uploaded image for project: 'Red Hat OpenBridge'
  1. Red Hat OpenBridge
  2. MGDOBR-1307

Deletion should happen in reverse order to creation

XMLWordPrintable

    • False
    • None
    • False

      Issue Description: 

      When deleting a Bridge or Processor we currently have the Control Plane first handle dependencies such as Kafka Topics, DNS entries etc and then delegate to the Data Plane to have the k8s objects destroyed.

      This has presented an issue with knative-eventing where the finaliser of a Broker is expecting the Kafka Topic to still be present.

      {"level":"error","ts":"2022-12-05T00:41:53.966Z","logger":"kafka-broker-controller","caller":"broker/reconciler.go:313","msg":"Returned an error","knative.dev/pod":"kafka-controller-7c759777fb-fkwhd","knative.dev/controller":"knative.dev.eventing-kafka-broker.control-plane.pkg.reconciler.broker.Reconciler","knative.dev/kind":"eventing.knative.dev.Broker","knative.dev/traceid":"f812faee-335b-4e7e-862d-fc2e0291b2d8","knative.dev/key":"ob-55029811/ob-07235687-864b-489c-a85e-2dcd57a01d3f","targetMethod":"ReconcileKind","error":"topics [ob-stable-brdg-07235687-864b-489c-a85e-2dcd57a01d3f] not present or invalid: invalid topic ob-stable-brdg-07235687-864b-489c-a85e-2dcd57a01d3f","stacktrace":"knative.dev/eventing/pkg/client/injection/reconciler/eventing/v1/broker.(*reconcilerImpl).Reconcile\n\t/remote-source/knative-kafka-broker/app/vendor/knative.dev/eventing/pkg/client/injection/reconciler/eventing/v1/broker/reconciler.go:313\nknative.dev/pkg/controller.(*Impl).processNextWorkItem\n\t/remote-source/knative-kafka-broker/app/vendor/knative.dev/pkg/controller/controller.go:542\nknative.dev/pkg/controller.(*Impl).RunContext.func3\n\t/remote-source/knative-kafka-broker/app/vendor/knative.dev/pkg/controller/controller.go:491"} 

      In reality it would be more advantageous to reverse the order of steps on deletion to those used during creation; i.e. have k8s delete objects first in the Data Plane and then, and only then, have the Control Plane delete any dependencies required by the Data Plane.  

      Acceptance Criteria:

      The steps taken during deletion are the reverse order of those used during creation. 

              Unassigned Unassigned
              manstis@redhat.com Michael Anstis
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: