Uploaded image for project: 'Tools (JBoss Tools)'
  1. Tools (JBoss Tools)
  2. JBIDE-15858

Env variables wizard: error when editing env variables for existing app if server does not support env variables

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • Major
    • 4.1.1.CR1
    • 4.1.1.Beta1
    • openshift
    • None
    • Hide
      1. ASSERT: make sure you have an account on a OS server that does NOT support env variables (ex. console.itos.redhat.com)
      2. ASSERT: make sure you have an existing application on this server
      3. EXEC: in OpenShift Explorer: pick "Edit Environment Variables..." in the context menu of your application

      Result:
      You get an error:

      In the Eclipse log you'll spot the following:

      com.openshift.client.OpenShiftRequestException: Could not find link "LIST_ENVIRONMENT_VARIABLES" in resource "ApplicationResource"
	at com.openshift.internal.client.AbstractOpenShiftResource.getLink(AbstractOpenShiftResource.java:123)
	at com.openshift.internal.client.AbstractOpenShiftResource$ServiceRequest.execute(AbstractOpenShiftResource.java:142)
	at com.openshift.internal.client.ApplicationResource.loadEnvironmentVariables(ApplicationResource.java:622)
	at com.openshift.internal.client.ApplicationResource.getOrLoadEnvironmentVariables(ApplicationResource.java:616)
	at com.openshift.internal.client.ApplicationResource.getEnvironmentVariables(ApplicationResource.java:611)
	at org.jboss.tools.openshift.express.internal.ui.wizard.environment.EnvironmentVariablesWizardModel.initVariablesFor(EnvironmentVariablesWizardModel.java:81)
	at org.jboss.tools.openshift.express.internal.ui.wizard.environment.EnvironmentVariablesWizardModel.initVariables(EnvironmentVariablesWizardModel.java:64)
	at org.jboss.tools.openshift.express.internal.ui.wizard.environment.EnvironmentVariablesWizardModel.loadEnvironmentVariables(EnvironmentVariablesWizardModel.java:58)
	at org.jboss.tools.openshift.express.internal.ui.wizard.environment.EnvironmentVariablesWizardPage$LoadEnvironmentVariablesJob.doRun(EnvironmentVariablesWizardPage.java:240)
	at org.jboss.tools.openshift.express.internal.ui.job.AbstractDelegatingMonitorJob.run(AbstractDelegatingMonitorJob.java:36)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:53)

      Expected result:
      You should not be able to edit environment variables if the server is not offering this capability.

      Show
      ASSERT: make sure you have an account on a OS server that does NOT support env variables (ex. console.itos.redhat.com) ASSERT: make sure you have an existing application on this server EXEC: in OpenShift Explorer: pick "Edit Environment Variables..." in the context menu of your application Result: You get an error: In the Eclipse log you'll spot the following: com.openshift.client.OpenShiftRequestException: Could not find link "LIST_ENVIRONMENT_VARIABLES" in resource "ApplicationResource" at com.openshift.internal.client.AbstractOpenShiftResource.getLink(AbstractOpenShiftResource.java:123) at com.openshift.internal.client.AbstractOpenShiftResource$ServiceRequest.execute(AbstractOpenShiftResource.java:142) at com.openshift.internal.client.ApplicationResource.loadEnvironmentVariables(ApplicationResource.java:622) at com.openshift.internal.client.ApplicationResource.getOrLoadEnvironmentVariables(ApplicationResource.java:616) at com.openshift.internal.client.ApplicationResource.getEnvironmentVariables(ApplicationResource.java:611) at org.jboss.tools.openshift.express.internal.ui.wizard.environment.EnvironmentVariablesWizardModel.initVariablesFor(EnvironmentVariablesWizardModel.java:81) at org.jboss.tools.openshift.express.internal.ui.wizard.environment.EnvironmentVariablesWizardModel.initVariables(EnvironmentVariablesWizardModel.java:64) at org.jboss.tools.openshift.express.internal.ui.wizard.environment.EnvironmentVariablesWizardModel.loadEnvironmentVariables(EnvironmentVariablesWizardModel.java:58) at org.jboss.tools.openshift.express.internal.ui.wizard.environment.EnvironmentVariablesWizardPage$LoadEnvironmentVariablesJob.doRun(EnvironmentVariablesWizardPage.java:240) at org.jboss.tools.openshift.express.internal.ui.job.AbstractDelegatingMonitorJob.run(AbstractDelegatingMonitorJob.java:36) at org.eclipse.core.internal.jobs.Worker.run(Worker.java:53) Expected result: You should not be able to edit environment variables if the server is not offering this capability.
    • Documentation (Ref Guide, User Guide, etc.)

    Description

      If OpenShift server does not support add/remove/modify environment variables it cause error. There should be some user-friendly dialog. See attached image. This is captured from opening shell with add/modify/remove environment variables (in context menu of application choose "Edit Environment Variables..."

      Another one is show after attempt to add variable.
      Other "Processing environment variables..."

      Probably good solution should show dialog "Server name does not support modifying environment variables" and don't open shell with table of environment variables (my opinion).

      Attachments

        Issue Links

          is blocked by

          Enhancement - An enhancement to or refactoring of existing functionality that is not configurable by an end user (typically a change made by an internal team that affects users) JBIDE-15597 Environmental Variables UI

          • Blocker - To be worked above all other priorities. This term is chosen when the severity of the issue is very high, has no workaround, or the effort for the change is comparatively low. Issues that may be very publicly visible and could generate significant media attention may also drive a higher priority.
          • Closed

          Enhancement - An enhancement to or refactoring of existing functionality that is not configurable by an end user (typically a change made by an internal team that affects users) JBIDE-16074 CLONE - Environmental Variables UI

          • Blocker - To be worked above all other priorities. This term is chosen when the severity of the issue is very high, has no workaround, or the effort for the change is comparatively low. Issues that may be very publicly visible and could generate significant media attention may also drive a higher priority.
          • Closed
          is cloned by

          Bug - A problem that impairs or prevents the functions of the product. JBIDE-16030 CLONE - Env variables wizard: error when editing env variables for existing app if server does not support env variables

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Closed
          relates to

          Bug - A problem that impairs or prevents the functions of the product. JBIDE-15861 Application wizard: env variables I provide have no effect if server does not support env vars on app creation

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Closed

          Bug - A problem that impairs or prevents the functions of the product. JBIDE-16031 CLONE - Application wizard: env variables I provide have no effect if server does not support env vars on app creation

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Closed

          Activity

            People

              manderse@redhat.com Max Andersen
              mlabuda_jira Marián Labuda (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: