Details
-
Bug
-
Resolution: Duplicate
-
Critical
-
None
-
None
-
None
-
False
-
None
-
False
Description
Description:
Taints cannot be deleted after CMS removed taints from machinepool
How reproducible:
100%
Steps:
- Prepare a classic rosa non-sts cluster
- Create a machinepool with taints set to the cluster
- Edit the machinepool via rosacli to remove the taints of the machinepool
- Check the machinesets in the cluster
Actual result:
- The taints inside cluster is not removed
Here is result in CMS:
lixue@Xue-Lis-MacBook-Pro ~ % rosa list machinepool -c 255s9ibgvsk7hmcuooca3r8bgm6ujqr3 ID AUTOSCALING REPLICAS INSTANCE TYPE LABELS TAINTS AVAILABILITY ZONES SUBNETS SPOT INSTANCES Default No 6 m5.xlarge label2/openshift.com=labelvalue2, example.label.1=test, label1/openshift.com=labelvalue1 us-east-1a, us-east-1b, us-east-1c subnet-09764aa23333e3bd3, subnet-0d828f9b107a5dc3a, subnet-0eec97eed7cc9592a, subnet-0c0b03f93ff6691f8, subnet-0e0b55ae2576be7f8, subnet-08ebb46657e93dae7 N/A mp-auto Yes 3-6 m5.xlarge us-east-1a, us-east-1b, us-east-1c subnet-0e0b55ae2576be7f8, subnet-0eec97eed7cc9592a, subnet-09764aa23333e3bd3 No
Here is result in machineset:
lixue@Xue-Lis-MacBook-Pro ~ % oc get machineset/sdq-ci-zerqu-2mtpx-mp-auto-us-east-1a -o json -n openshift-machine-api
{
"apiVersion": "machine.openshift.io/v1beta1",
"kind": "MachineSet",
"metadata": {
"annotations": {
"autoscaling.openshift.io/machineautoscaler": "openshift-machine-api/sdq-ci-zerqu-2mtpx-mp-auto-us-east-1a",
"machine.openshift.io/GPU": "0",
"machine.openshift.io/cluster-api-autoscaler-node-group-max-size": "2",
"machine.openshift.io/cluster-api-autoscaler-node-group-min-size": "1",
"machine.openshift.io/memoryMb": "16384",
"machine.openshift.io/vCPU": "4"
},
"creationTimestamp": "2023-07-24T08:25:33Z",
"generation": 2,
"labels": {
"hive.openshift.io/machine-pool": "mp-auto",
"hive.openshift.io/managed": "true",
"machine.openshift.io/cluster-api-cluster": "sdq-ci-zerqu-2mtpx"
},
"name": "sdq-ci-zerqu-2mtpx-mp-auto-us-east-1a",
"namespace": "openshift-machine-api",
"resourceVersion": "207681",
"uid": "da0e6da0-47ce-4cb8-a15b-b15afab6fc1c"
},
"spec": {
"replicas": 1,
"selector": {
"matchLabels": {
"machine.openshift.io/cluster-api-cluster": "sdq-ci-zerqu-2mtpx",
"machine.openshift.io/cluster-api-machineset": "sdq-ci-zerqu-2mtpx-mp-auto-us-east-1a"
}
},
"template": {
"metadata": {
"labels": {
"machine.openshift.io/cluster-api-cluster": "sdq-ci-zerqu-2mtpx",
"machine.openshift.io/cluster-api-machine-role": "mp-auto",
"machine.openshift.io/cluster-api-machine-type": "mp-auto",
"machine.openshift.io/cluster-api-machineset": "sdq-ci-zerqu-2mtpx-mp-auto-us-east-1a"
}
},
"spec": {
"lifecycleHooks": {},
"metadata": {},
"providerSpec": {
"value": {
"ami": {
"id": "ami-0e2a30fbaf81ecdfa"
},
"apiVersion": "machine.openshift.io/v1beta1",
"blockDevices": [
{
"ebs": {
"encrypted": true,
"iops": 0,
"kmsKey": {
"arn": "arn:aws:kms:us-east-1:301721915996:key/9b63e2fb-b78b-4427-b7fd-a180be4d8206"
},
"volumeSize": 300,
"volumeType": "gp3"
}
}
],
"credentialsSecret": {
"name": "aws-cloud-credentials"
},
"deviceIndex": 0,
"iamInstanceProfile": {
"id": "sdq-ci-zerqu-2mtpx-worker-profile"
},
"instanceType": "m5.xlarge",
"kind": "AWSMachineProviderConfig",
"metadata": {
"creationTimestamp": null
},
"metadataServiceOptions": {},
"placement": {
"availabilityZone": "us-east-1a",
"region": "us-east-1"
},
"securityGroups": [
{
"filters": [
{
"name": "tag:Name",
"values": [
"sdq-ci-zerqu-2mtpx-worker-sg"
]
}
]
}
],
"subnet": {
"id": "subnet-09764aa23333e3bd3"
},
"tags": [
{
"name": "kubernetes.io/cluster/sdq-ci-zerqu-2mtpx",
"value": "owned"
}
],
"userDataSecret": {
"name": "worker-user-data"
}
}
},
"taints": [
{
"effect": "NoSchedule",
"key": "t1",
"value": "v1"
}
]
}
}
},
"status": {
"availableReplicas": 1,
"fullyLabeledReplicas": 1,
"observedGeneration": 2,
"readyReplicas": 1,
"replicas": 1
}
}
Here is machinepool in machinepool CR on HIVE:
{
"kind": "MachinePool",
"apiVersion": "hive.openshift.io/v1",
"metadata": {
"name": "sdq-ci-zerqu-mp-auto",
"namespace": "uhc-staging-255s9ibgvsk7hmcuooca3r8bgm6ujqr3",
"uid": "90f08d8e-ba9a-47d6-accb-9f125dd189d6",
"resourceVersion": "1499665540",
"generation": 3,
"creationTimestamp": "2023-07-24T08:25:32Z",
"labels": {
"api.openshift.com/id": "255s9ibgvsk7hmcuooca3r8bgm6ujqr3"
},
"annotations": {
"hive.openshift.io/image-id-override": "ami-0e2a30fbaf81ecdfa"
},
"finalizers": [
"hive.openshift.io/remotemachineset"
],
"managedFields": [
{
"manager": "manager",
"operation": "Update",
"apiVersion": "hive.openshift.io/v1",
"time": "2023-07-24T08:25:32Z",
"fieldsType": "FieldsV1",
"fieldsV1": {
"f:metadata": {
"f:finalizers": {
".": {},
"v:\"hive.openshift.io/remotemachineset\"": {}
}
}
}
},
{
"manager": "manager",
"operation": "Update",
"apiVersion": "hive.openshift.io/v1",
"time": "2023-07-24T08:35:34Z",
"fieldsType": "FieldsV1",
"fieldsV1": {
"f:status": {
".": {},
"f:conditions": {},
"f:machineSets": {},
"f:replicas": {}
}
},
"subresource": "status"
},
{
"manager": "clusters-service",
"operation": "Update",
"apiVersion": "hive.openshift.io/v1",
"time": "2023-07-24T10:33:31Z",
"fieldsType": "FieldsV1",
"fieldsV1": {
"f:metadata": {
"f:annotations": {
".": {},
"f:hive.openshift.io/image-id-override": {}
},
"f:labels": {
".": {},
"f:api.openshift.com/id": {}
}
},
"f:spec": {
".": {},
"f:autoscaling": {
".": {},
"f:maxReplicas": {},
"f:minReplicas": {}
},
"f:clusterDeploymentRef": {},
"f:name": {},
"f:platform": {
".": {},
"f:aws": {
".": {},
"f:rootVolume": {
".": {},
"f:kmsKeyARN": {},
"f:size": {},
"f:type": {}
},
"f:subnets": {},
"f:type": {},
"f:zones": {}
}
}
}
}
}
]
},
"spec": {
"clusterDeploymentRef": {
"name": "sdq-ci-zerqu"
},
"name": "mp-auto",
"autoscaling": {
"minReplicas": 3,
"maxReplicas": 6
},
"platform": {
"aws": {
"zones": [
"us-east-1a",
"us-east-1b",
"us-east-1c"
],
"subnets": [
"subnet-0e0b55ae2576be7f8",
"subnet-0eec97eed7cc9592a",
"subnet-09764aa23333e3bd3"
],
"type": "m5.xlarge",
"rootVolume": {
"size": 300,
"type": "gp3",
"kmsKeyARN": "arn:aws:kms:us-east-1:301721915996:key/9b63e2fb-b78b-4427-b7fd-a180be4d8206"
}
}
}
},
"status": {
"replicas": 3,
"machineSets": [
{
"name": "sdq-ci-zerqu-2mtpx-mp-auto-us-east-1a",
"replicas": 1,
"readyReplicas": 1,
"minReplicas": 1,
"maxReplicas": 2
},
{
"name": "sdq-ci-zerqu-2mtpx-mp-auto-us-east-1b",
"replicas": 1,
"readyReplicas": 1,
"minReplicas": 1,
"maxReplicas": 2
},
{
"name": "sdq-ci-zerqu-2mtpx-mp-auto-us-east-1c",
"replicas": 1,
"readyReplicas": 1,
"minReplicas": 1,
"maxReplicas": 2
}
],
"conditions": [
{
"type": "NotEnoughReplicas",
"status": "False",
"lastProbeTime": "2023-07-24T08:25:33Z",
"lastTransitionTime": "2023-07-24T08:25:33Z",
"reason": "EnoughReplicas",
"message": "The MachinePool has sufficient replicas for each MachineSet"
},
{
"type": "NoMachinePoolNameLeasesAvailable",
"status": "Unknown",
"lastProbeTime": "2023-07-24T08:25:32Z",
"lastTransitionTime": "2023-07-24T08:25:32Z",
"reason": "Initialized",
"message": "Condition Initialized"
},
{
"type": "InvalidSubnets",
"status": "False",
"lastProbeTime": "2023-07-24T08:25:33Z",
"lastTransitionTime": "2023-07-24T08:25:33Z",
"reason": "ValidSubnets",
"message": "Subnets are valid"
},
{
"type": "UnsupportedConfiguration",
"status": "False",
"lastProbeTime": "2023-07-24T08:25:33Z",
"lastTransitionTime": "2023-07-24T08:25:33Z",
"reason": "ConfigurationSupported",
"message": "The configuration is supported"
}
]
}
}
