Uploaded image for project: 'OpenShift Hive'
  1. OpenShift Hive
  2. HIVE-2035

Merge Labels/Taints configured in MachinePool when applying to MachineSets

    XMLWordPrintable

Details

    • Story
    • Resolution: Done
    • Major
    • None
    • None
    • False
    • None
    • False

    Description

      Origin discussion: https://coreos.slack.com/archives/CTZTHFQRH/p1663650424364439

      When Labels or Taints are configured in the MachinePool CR, the controller currently completely overrides any existing Label or Taints configurations on the MachineSet CRs.  Therefore, if a user had directly applied any customized Label or Taint configuration it will be wiped at the next reconcile loop of the controller; this may lead to some confusing behavior like in the origin Slack discussion.

      This would be an enhancement for Hive to support a merge strategy to apply the configured Labels/Taints in the MachinePool CR without completely replacing any directly applied changes on the MachineSet Label/Taint configurations.

      https://github.com/openshift/hive/blob/master/pkg/controller/machinepool/machinepool_controller.go#L454-L461

      https://github.com/openshift/hive/blob/master/pkg/controller/machinepool/machinepool_controller.go#L584-L598

      Attachments

        Activity

          People

            sumehta Suhani Mehta
            showeimer Sho Weimer
            Feilian Xie Feilian Xie
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: