-
Story
-
Resolution: Unresolved
-
Undefined
-
None
-
None
-
None
-
None
-
None
-
False
-
-
False
-
8
-
None
-
None
-
OCP Console - Sprint 283
There are a few remaining instances of createModalLauncher which use either the history object or react-router/react-router-dom/react-router-dom-v5-compat.
We cannot have two CompatRouters in one project, so we need to remove all remaining instances of createModalLauncher that use react-router, so that we can complete the react router upgrade
AC:
- Overall - remove React router context:
- Examine all the createModalLaunchers in console that use react-router and replace them with a solution which does not need a separate react render tree
- Remove createModalLauncher and createModal from frontend/public/components/factory/modal.tsx
Follow up:
- Replace temporary solution with a permanent fix that utilizes useOverlay.
- Replace and remove legacy ModalWrapper, ModalTitle, ModalBody, ModalFooter, ModalSubmitFooter components from frontend/public/components/factory/modal.tsx with PatternFly equivalents as these legacy component duplicate functionality in PatternFly and may result in cosmetic differences.
- blocks
-
CONSOLE-4392 Dependencies: Upgrade to react-router v7
-
- To Do
-
- is related to
-
CONSOLE-4587 OCP 4.20 - Use useOverlay hook in place of createModalLauncher.
-
- Closed
-
-
CONSOLE-4754 OCP 4.21 - Use useOverlay hook in place of createModalLauncher.
-
- Closed
-
- relates to
-
CONSOLE-5022 OCP 4.23 - Use useOverlay hook in place of createModalLauncher.
-
- New
-
- links to
1.
|
Group A files for conversion |
|
In Progress | |
Robb Hamilton |
2.
|
Group B files for conversion |
|
To Do | |
Steve goodwin |