-
Epic
-
Resolution: Unresolved
-
Undefined
-
None
-
None
-
None
-
Refactor createModalLauncher consumers to be compatible with useModal hook
-
None
-
9% To Do, 18% In Progress, 73% Done
-
False
-
-
False
-
None
-
None
-
None
Epic Goal
- As part of the work on react-router v5 drop, we need to migrate from the createModalLauncher instances in our codebase and use the useOverlay hook instead.
- To use useOverlay hook we have to firstly refactor createModalLauncher consumers to a hook/FC form. This applies mainly to the ActionFactories and menuActions throughout console, as their refactor will result in many changes on its own.
- After the refactor of these factories, we would follow it up by createModalLauncher drop and introduction of new hook modal launcher providers, that will utilize useOverlay hook.
- Isolated modals and actions that are used only in couple of places, would be refactored together with the createModalLauncher drop.
Why is this important?
- react-router v6 has problems with our createModalLauncher implementation, since it relies on a secondary Router instance, that causes errors on modals launched via createModalLauncher.
- Migrating away from the createModalLauncher will allow us to proceed with the upgrade to react-router v6.
Scenarios
- ...
Acceptance Criteria
- CI - MUST be running successfully with tests automated
- Release Technical Enablement - Provide necessary release enablement details and documents.
- All consumers of createModalLauncher are converted to hook/FC form.
Dependencies (internal and external)
- ...
Previous Work (Optional):
- …
Open questions::
- …
Done Checklist
- CI - CI is running, tests are automated and merged.
- Release Enablement <link to Feature Enablement Presentation>
- DEV - Upstream code and tests merged: <link to meaningful PR or GitHub Issue>
- DEV - Upstream documentation merged: <link to meaningful PR or GitHub Issue>
- DEV - Downstream build attached to advisory: <link to errata>
- QE - Test plans in Polarion: <link or reference to Polarion>
- QE - Automated tests merged: <link or reference to automated tests>
- DOC - Downstream documentation merged: <link to meaningful PR>
- clones
-
CONSOLE-4587 OCP 4.20 - Use useOverlay hook in place of createModalLauncher.
-
- Dev Complete
-