Uploaded image for project: 'OpenShift Console'
  1. OpenShift Console
  2. CONSOLE-5012

Ensure react-router dependent modals do not use createModalLauncher

XMLWordPrintable

    • Icon: Story Story
    • Resolution: Unresolved
    • Icon: Undefined Undefined
    • None
    • None
    • None
    • None
    • None
    • None
    • OCP Console - Sprint 283

      There are a few remaining instances of createModalLauncher which use either the history object or react-router/react-router-dom/react-router-dom-v5-compat. 

      We cannot have two CompatRouters in one project, so we need to remove all remaining instances of createModalLauncher that use react-router, so that we can complete the react router upgrade

       

      AC:

      • Overall - remove React router context:
        • Examine all the createModalLaunchers in console that use react-router and replace them with a solution which does not need a separate react render tree
        • Remove createModalLauncher and createModal from frontend/public/components/factory/modal.tsx

      Follow up: 

      • Replace temporary solution with a permanent fix that utilizes useOverlay.
      • Replace and remove legacy ModalWrapperModalTitleModalBodyModalFooter, ModalSubmitFooter components from frontend/public/components/factory/modal.tsx with PatternFly equivalents as these legacy component duplicate functionality in PatternFly and may result in cosmetic differences.

              sgoodwin_redhat Steve goodwin
              rh-ee-jaclee Jackson Lee
              None
              Robb Hamilton
              None
              None
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated: