Uploaded image for project: 'OpenShift Windows Containers'
  1. OpenShift Windows Containers
  2. WINC-1654

Add [WC-BYOH] feature tag to identify BYOH-specific tests

XMLWordPrintable

    • Quality / Stability / Reliability
    • False
    • Hide

      None

      Show
      None
    • False
    • None
    • None
    • None
    • None

      Add [WC-BYOH] feature-level tag to identify BYOH-specific Windows Containers tests and enable selective execution on platforms that support BYOH provisioning.

      Background

      Currently, BYOH (Bring Your Own Host) Windows Containers tests run without selective filtering. We need a feature-level tag to:

      • Identify tests that specifically test BYOH functionality
      • Allow running BYOH tests ONLY on platforms with BYOH support (vSphere IPI, Azure IPI)
      • Prevent BYOH tests from running on platforms without BYOH support (AWS IPI, GCP IPI)

      Approach Change (Per PR Review)

      Original plan: Use framework-level "Byoh-" prefix
      Final implementation: Use feature-level [WC-BYOH] tag

      Rationale (from @Phaow review feedback):

      • BYOH is a Windows Containers feature, not a framework-wide concept
      • Follow existing patterns like [AWS-EBS-CSI], [Azure-Disk-CSI-Driver]
      • Feature tags work with standard Ginkgo label filters without pipeline changes

      What This Story Delivers

      Test Name Updates

      Update 5 BYOH test names in test/extended/winc/winc.go to include [WC-BYOH] tag:

      • OCP-42496 - Configure Windows instance with DNS
      • OCP-42484 - Configure Windows instance with IP
      • OCP-42516 - Configure Windows instance with IP and DNS
      • OCP-44099 - Secure Windows workers username annotation
      • OCP-82694 - Verify containerd path removal

      Platform-Specific CI Configuration (Follow-up)

      Update TEST_SCENARIOS in Prow CI for platforms with BYOH support:

      • vSphere IPI: TEST_SCENARIOS='Windows_Containers|[WC-BYOH]'
      • Azure IPI: TEST_SCENARIOS='Windows_Containers|[WC-BYOH]'
      • AWS IPI: No changes (no BYOH support)
      • GCP IPI: No changes (no BYOH support)

      Files Changed

      openshift-tests-private Repository (PR #29149)

      • test/extended/winc/winc.go - Add [WC-BYOH] tag to 5 test names
      • pipeline/handleresult.py - NO CHANGES (feature tag, not framework label)

      openshift/release Repository (Follow-up - WINC-1695)

      • ci-operator/config/openshift-priv/openshift-tests-private/openshift-priv-openshift-tests-private-main.yaml
        • Update vSphere IPI job with WC-BYOH scenario
        • Update Azure IPI job with WC-BYOH scenario

      Technical Details

      Test Name Pattern

      FROM:
      g.It("Author:rrasouli-Byoh-NonPreRelease-Longduration-Critical-42496-Configure Windows instance with DNS [Slow] [Disruptive]", func() {
      
      TO:
      g.It("Author:rrasouli-NonPreRelease-Longduration-Critical-42496-Configure Windows instance with DNS [WC-BYOH] [Slow] [Disruptive]", func() {
      

      CI Job Configuration

      # vSphere IPI (supports BYOH)
      env:
        TEST_SCENARIOS: 'Windows_Containers|\[WC-BYOH\]'
        TEST_FILTERS: ~ChkUpgrade&;~ConnectedOnly&;Smokerun&
      
      h1. Azure IPI (supports BYOH)
      env:
        TEST_SCENARIOS: 'Windows_Containers|\[WC-BYOH\]'
        TEST_FILTERS: ~ChkUpgrade&;~ConnectedOnly&;Smokerun&
      
      h1. AWS IPI (no BYOH support - no changes)
      env:
        TEST_SCENARIOS: Windows_Containers
        TEST_FILTERS: ~ChkUpgrade&;~ConnectedOnly&;Smokerun&
      

      Test Filtering

      Local Testing

      # Run only WC-BYOH tests
      TEST_SCENARIOS='\[WC-BYOH\]' ./bin/extended-platform-tests run all
      
      h1. Verify tests detected
      ./bin/extended-platform-tests run all --dry-run | grep "WC-BYOH"
      

      Platform Isolation

      All WC-BYOH tests are NonPreRelease and Longduration (not Smokerun), so they:

      • Don't run on existing Windows jobs (which only run Smokerun tests)
      • Only run when explicitly included via TEST_SCENARIOS

      Subtasks

      1. WINC-1655 - Add [WC-BYOH] test tag (PR #29149) - IN PROGRESS
      2. WINC-1695 - Update Prow CI TEST_SCENARIOS - TO DO

      Acceptance Criteria

      • [WC-BYOH] tag added to all 5 BYOH tests
      • Tests detected with TEST_SCENARIOS='[WC-BYOH]'
      • No changes to pipeline/handleresult.py (feature tag, not framework)
      • Build succeeds
      • PR #29149 merged
      • Follow-up PR in openshift/release repo (WINC-1695)

      Related Work

      • Epic: WINC-1473 (BYOH in Prow)
      • PR: #29149 (openshift-tests-private)
      • Follow-up: WINC-1695 (Prow CI configuration)

              Unassigned Unassigned
              rrasouli Aharon Rasouli
              None
              None
              None
              None
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated: