Uploaded image for project: 'WildFly'
  1. WildFly
  2. WFLY-5966

Validate requirement for modules previously exported by javax.ejb.api

    XMLWordPrintable

    Details

      Description

      The WFLY-5922 fix removed the exporting of a number of modules from javax.ejb.api. That introduced some problems with modules that depended on those exported packages no longer having visibility to needed classes, so to prevent problems I blindly added a commit to the module.xml for each module that depended upon javax.ejb.api to add a dependency set like this:

              <!-- TODO validate the need for these and remove if not needed.
                   Prior to WFLY-5922 they were exported by javax.ejb.api. -->
              <module name="javax.api"/>
              <module name="javax.transaction.api"/>
              <module name="javax.xml.rpc.api"/>
              <module name="javax.rmi.api"/>
              <module name="org.omg.api"/>
      

      If a module already had a dep on one of those, it's not in the block.

      This task is to check each of these modules and replace that block with normal dependency declarations for any that are truly needed.

      Affected modules:

      feature-pack/src/main/resources/modules/system/layers/base/javax/management/j2ee/api/main/module.xml
      feature-pack/src/main/resources/modules/system/layers/base/org/jboss/as/ejb3/main/module.xml
      feature-pack/src/main/resources/modules/system/layers/base/org/jboss/as/jsr77/main/module.xml
      feature-pack/src/main/resources/modules/system/layers/base/org/jboss/as/webservices/main/module.xml
      feature-pack/src/main/resources/modules/system/layers/base/org/jboss/as/weld/main/module.xml
      feature-pack/src/main/resources/modules/system/layers/base/org/jboss/as/xts/main/module.xml
      feature-pack/src/main/resources/modules/system/layers/base/org/jboss/ejb-client/main/module.xml
      feature-pack/src/main/resources/modules/system/layers/base/org/jboss/ejb3/main/module.xml
      feature-pack/src/main/resources/modules/system/layers/base/org/jboss/iiop-client/main/module.xml
      feature-pack/src/main/resources/modules/system/layers/base/org/jboss/metadata/appclient/main/module.xml
      feature-pack/src/main/resources/modules/system/layers/base/org/jboss/metadata/ejb/main/module.xml
      feature-pack/src/main/resources/modules/system/layers/base/org/jboss/narayana/compensations/main/module.xml
      feature-pack/src/main/resources/modules/system/layers/base/org/jboss/narayana/rts/main/module.xml
      feature-pack/src/main/resources/modules/system/layers/base/org/jboss/narayana/txframework/main/module.xml
      feature-pack/src/main/resources/modules/system/layers/base/org/jboss/weld/core/main/module.xml
      feature-pack/src/main/resources/modules/system/layers/base/org/jboss/ws/common/main/module.xml
      feature-pack/src/main/resources/modules/system/layers/base/org/jboss/xts/main/module.xml
      feature-pack/src/main/resources/modules/system/layers/base/org/wildfly/extension/rts/main/module.xml
      feature-pack/src/main/resources/modules/system/layers/base/org/jboss/as/jpa/main/module.xml
      feature-pack/src/main/resources/modules/system/layers/base/org/jboss/as/jpa/spi/main/module.xml

      feature-pack/src/main/resources/modules/system/layers/base/javaee/api/main/module.xml

      The following modules were indirectly affected via their dependency on javaee.api, which in turn exports javax.ejb.api:

      feature-pack/src/main/resources/modules/system/layers/base/org/jberet/jberet-core/main/module.xml
      jsf/multi-jsf-installer/src/main/resources/mojarra-impl-module.xml
      jsf/multi-jsf-installer/src/main/resources/myfaces-impl-module.xml
      feature-pack/src/main/resources/modules/system/layers/base/com/sun/jsf-impl/main/module.xml
      jsf/subsystem/src/test/resources/modules/com/sun/jsf-impl/main/module.xml
      jsf/subsystem/src/test/resources/modules/com/sun/jsf-impl/myfaces/module.xml
      jsf/subsystem/src/test/resources/modules2/com/sun/jsf-impl/myfaces2/module.xml

        Attachments

          Issue Links

          1.
          Validate requirement for modules previously exported by javax.ejb.api on org.jboss.as.jsr77 Sub-task Closed Major Yeray Borges Santana
          2.
          Validate requirement for modules previously exported by javax.ejb.api on org.jboss.as.xts Sub-task Closed Major Yeray Borges Santana
          3.
          Validate requirement for modules previously exported by javax.ejb.api on org.wildfly.extension.rts Sub-task Closed Major Yeray Borges Santana
          4.
          Validate requirement for modules previously exported by javax.ejb.api on org.jberet.jberet-core Sub-task Closed Major Yeray Borges Santana
          5.
          Validate requirement for modules previously exported by javax.ejb.api on org.jboss.ws.common Sub-task Closed Major Yeray Borges Santana
          6.
          Validate requirement for modules previously exported by javax.ejb.api on javax.management.j2ee.api Sub-task Closed Major Yeray Borges Santana
          7.
          Validate requirement for modules previously exported by javax.ejb.api on org.jboss.metadata.ejb Sub-task Closed Major Yeray Borges Santana
          8.
          Validate requirement for modules previously exported by javax.ejb.api on ejb3 related modules Sub-task Closed Major Yeray Borges Santana
          9.
          Validate requirement for modules previously exported by javax.ejb.api on org.jboss.metadata.appclient Sub-task Closed Major Yeray Borges Santana
          10.
          Validate requirement for modules previously exported by javax.ejb.api on org.jboss.narayana.txframework Sub-task Closed Major Yeray Borges Santana
          11.
          Validate requirement for modules previously exported by javax.ejb.api on org.jboss.as.webservices Sub-task Closed Major Yeray Borges Santana
          12.
          Validate requirement for modules previously exported by javax.ejb.api on org.jboss.iiop-client Sub-task Closed Major Yeray Borges Santana
          13.
          Validate requirement for modules previously exported by javax.ejb.api on JSF implementations Sub-task Closed Major Yeray Borges Santana

            Activity

              People

              Assignee:
              yborgess1@redhat.com Yeray Borges Santana
              Reporter:
              bstansbe@redhat.com Brian Stansberry
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: