This is a top level task to be broken into subtasks reasonably scoped to parts of the code that can be efficiently reviewed by relevant SMEs.

All uses of the ModuleIdentifier class are to be removed from the wildfly/wildfly repo code base. Only exceptions are:

1) Uses that are required to comply with SPIs from WildFly Core.

2) Places where ModuleIdentifier appears in supported end user or external extension developer APIs.

I doubt there are any cases of #2; if there are such APIs must be deprecated for removal with an alternative string based variant added.

There will be an analogous WFCORE issue, so we may end up iterating on this a bit as changes in Core reduced the number of cases of the #1 exception. A quick scan though leads me to believe that most uses of ModuleIdentifier can be trivially replaced.