This is a top level task to be broken into subtasks reasonably scoped to parts of the code that can be efficiently reviewed by relevant SMEs.

All uses of the ModuleIdentifier class are to be removed from the wildfly/wildfly-core repo code base. Only exceptions are places where ModuleIdentifier appears in supported end user or external extension developer APIs.

Where there are such APIs they must be deprecated for removal with an alternative string based variant added.

The big issue 'API' here are the contants in org.jboss.as.server.deployment.Attachments.