Uploaded image for project: 'WildFly Core'
  1. WildFly Core
  2. WFCORE-7438

Deprecate BaseAttributeTransformationDescriptionBuilder methods that take String names of AttributeDefinitions

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Done
    • Icon: Major Major
    • 31.0.0.Beta3
    • None
    • Management
    • None

      BaseAttributeTransformationDescriptionBuilder has a number of methods that take String... attributeName parameters instead of AttributeDefinition... attributes. Deprecate them for removal.

      It's been a decade since it was valid for management code to use non-AttributeDefinition-based attributes or operation parameters so we don't need these methods. Their implementation cannot take advantage of things available via AttributeDefinition, thus limiting what a proper impl can do.

      Current uses (some methods are not used at all): EDIT – what's below is only what's in full WildFly; my scan wasn't set to pick up uses in WF Core.

      Abstract method
          addRejectCheck(RejectAttributeChecker, String...)
      Usages or usages of base method in Project and Libraries  (41 usages found)
          Unclassified  (41 usages found)
              wildfly-clustering-jgroups-extension  (1 usage found)
                  org.jboss.as.clustering.jgroups.subsystem  (1 usage found)
                      AuthTokenResourceTransformer  (1 usage found)
                          accept(ModelVersion)  (1 usage found)
                              30 .addRejectCheck(CredentialReference.REJECT_CREDENTIAL_REFERENCE_WITH_BOTH_STORE_AND_CLEAR_TEXT, AuthTokenResourceDefinitionRegistrar.SHARED_SECRET.getName())
              wildfly-elytron-oidc-client-subsystem  (38 usages found)
                  org.wildfly.extension.elytron.oidc  (38 usages found)
                      ElytronOidcSubsystemTransformers  (38 usages found)
                          from3(ChainedTransformationDescriptionBuilder)  (2 usages found)
                              69 .addRejectCheck(RejectAttributeChecker.DEFINED, SCOPE)
                              75 .addRejectCheck(RejectAttributeChecker.DEFINED, SCOPE)
                          from4(ChainedTransformationDescriptionBuilder)  (36 usages found)
                              84 .addRejectCheck(RejectAttributeChecker.DEFINED, AUTHENTICATION_REQUEST_FORMAT)
                              86 .addRejectCheck(RejectAttributeChecker.DEFINED, REQUEST_OBJECT_ENCRYPTION_ALG_VALUE)
                              88 .addRejectCheck(RejectAttributeChecker.DEFINED, REQUEST_OBJECT_ENCRYPTION_ENC_VALUE)
                              90 .addRejectCheck(RejectAttributeChecker.DEFINED, REQUEST_OBJECT_SIGNING_ALGORITHM)
                              92 .addRejectCheck(RejectAttributeChecker.DEFINED, REQUEST_OBJECT_SIGNING_KEY_ALIAS)
                              94 .addRejectCheck(RejectAttributeChecker.DEFINED, REQUEST_OBJECT_SIGNING_KEY_PASSWORD)
                              96 .addRejectCheck(RejectAttributeChecker.DEFINED, REQUEST_OBJECT_SIGNING_KEYSTORE_FILE)
                              98 .addRejectCheck(RejectAttributeChecker.DEFINED, REQUEST_OBJECT_SIGNING_KEYSTORE_PASSWORD)
                              100 .addRejectCheck(RejectAttributeChecker.DEFINED, REQUEST_OBJECT_SIGNING_KEYSTORE_TYPE)
                              106 .addRejectCheck(RejectAttributeChecker.DEFINED, AUTHENTICATION_REQUEST_FORMAT)
                              108 .addRejectCheck(RejectAttributeChecker.DEFINED, REQUEST_OBJECT_ENCRYPTION_ALG_VALUE)
                              110 .addRejectCheck(RejectAttributeChecker.DEFINED, REQUEST_OBJECT_ENCRYPTION_ENC_VALUE)
                              112 .addRejectCheck(RejectAttributeChecker.DEFINED, REQUEST_OBJECT_SIGNING_ALGORITHM)
                              114 .addRejectCheck(RejectAttributeChecker.DEFINED, REQUEST_OBJECT_SIGNING_KEY_ALIAS)
                              116 .addRejectCheck(RejectAttributeChecker.DEFINED, REQUEST_OBJECT_SIGNING_KEY_PASSWORD)
                              118 .addRejectCheck(RejectAttributeChecker.DEFINED, REQUEST_OBJECT_SIGNING_KEYSTORE_FILE)
                              120 .addRejectCheck(RejectAttributeChecker.DEFINED, REQUEST_OBJECT_SIGNING_KEYSTORE_PASSWORD)
                              122 .addRejectCheck(RejectAttributeChecker.DEFINED, REQUEST_OBJECT_SIGNING_KEYSTORE_TYPE)
                              128 .addRejectCheck(RejectAttributeChecker.DEFINED, AUTHENTICATION_REQUEST_FORMAT)
                              130 .addRejectCheck(RejectAttributeChecker.DEFINED, REQUEST_OBJECT_ENCRYPTION_ALG_VALUE)
                              132 .addRejectCheck(RejectAttributeChecker.DEFINED, REQUEST_OBJECT_ENCRYPTION_ENC_VALUE)
                              134 .addRejectCheck(RejectAttributeChecker.DEFINED, REQUEST_OBJECT_SIGNING_ALGORITHM)
                              136 .addRejectCheck(RejectAttributeChecker.DEFINED, REQUEST_OBJECT_SIGNING_KEY_ALIAS)
                              138 .addRejectCheck(RejectAttributeChecker.DEFINED, REQUEST_OBJECT_SIGNING_KEY_PASSWORD)
                              140 .addRejectCheck(RejectAttributeChecker.DEFINED, REQUEST_OBJECT_SIGNING_KEYSTORE_FILE)
                              142 .addRejectCheck(RejectAttributeChecker.DEFINED, REQUEST_OBJECT_SIGNING_KEYSTORE_PASSWORD)
                              144 .addRejectCheck(RejectAttributeChecker.DEFINED, REQUEST_OBJECT_SIGNING_KEYSTORE_TYPE)
                              150 .addRejectCheck(RejectAttributeChecker.DEFINED, AUTHENTICATION_REQUEST_FORMAT)
                              152 .addRejectCheck(RejectAttributeChecker.DEFINED, REQUEST_OBJECT_ENCRYPTION_ALG_VALUE)
                              154 .addRejectCheck(RejectAttributeChecker.DEFINED, REQUEST_OBJECT_ENCRYPTION_ENC_VALUE)
                              156 .addRejectCheck(RejectAttributeChecker.DEFINED, REQUEST_OBJECT_SIGNING_ALGORITHM)
                              158 .addRejectCheck(RejectAttributeChecker.DEFINED, REQUEST_OBJECT_SIGNING_KEY_ALIAS)
                              160 .addRejectCheck(RejectAttributeChecker.DEFINED, REQUEST_OBJECT_SIGNING_KEY_PASSWORD)
                              162 .addRejectCheck(RejectAttributeChecker.DEFINED, REQUEST_OBJECT_SIGNING_KEYSTORE_FILE)
                              164 .addRejectCheck(RejectAttributeChecker.DEFINED, REQUEST_OBJECT_SIGNING_KEYSTORE_PASSWORD)
                              166 .addRejectCheck(RejectAttributeChecker.DEFINED, REQUEST_OBJECT_SIGNING_KEYSTORE_TYPE)
              wildfly-security  (1 usage found)
                  org.jboss.as.security  (1 usage found)
                      SecurityTransformers  (1 usage found)
                          registerTransformers_1_3_0(SubsystemTransformerRegistration)  (1 usage found)
                              56 .addRejectCheck(RejectAttributeChecker.DEFINED, MODULE).end();
              Maven: org.wildfly.core:wildfly-controller:31.0.0.Beta2  (1 usage found)
                  org.jboss.as.controller.transform.description  (1 usage found)
                      AttributeTransformationDescriptionBuilderImpl  (1 usage found)
                          addRejectChecks(List<RejectAttributeChecker>, String...)  (1 usage found)
                              92 addRejectCheck(rejectChecker, rejectedAttributes);
      						
      					
      Abstract method
          setDiscard(DiscardAttributeChecker, String...)
      Usages or usages of base method in Project and Libraries  (41 usages found)
          Unclassified  (41 usages found)
              wildfly-clustering-web-extension  (1 usage found)
                  org.wildfly.extension.clustering.web  (1 usage found)
                      HotRodSessionManagementResourceTransformer  (1 usage found)
                          accept(ModelVersion)  (1 usage found)
                              33 .setDiscard(DiscardAttributeChecker.ALWAYS, HotRodSessionManagementResourceDefinitionRegistrar.EXPIRATION_THREAD_POOL_SIZE.getName())
              wildfly-connector  (1 usage found)
                  org.jboss.as.connector.subsystems.resourceadapters  (1 usage found)
                      ResourceAdaptersTransformers  (1 usage found)
                          register610Transformers(ResourceTransformationDescriptionBuilder)  (1 usage found)
                              62 parentBuilder.getAttributeBuilder().setDiscard(DiscardAttributeChecker.ALWAYS, REPORT_DIRECTORY_NAME);
              wildfly-elytron-oidc-client-subsystem  (38 usages found)
                  org.wildfly.extension.elytron.oidc  (38 usages found)
                      ElytronOidcSubsystemTransformers  (38 usages found)
                          from3(ChainedTransformationDescriptionBuilder)  (2 usages found)
                              70 .setDiscard(DiscardAttributeChecker.ALWAYS, SCOPE)
                              76 .setDiscard(DiscardAttributeChecker.ALWAYS, SCOPE)
                          from4(ChainedTransformationDescriptionBuilder)  (36 usages found)
                              85 .setDiscard(DiscardAttributeChecker.ALWAYS, AUTHENTICATION_REQUEST_FORMAT)
                              87 .setDiscard(DiscardAttributeChecker.ALWAYS, REQUEST_OBJECT_ENCRYPTION_ALG_VALUE)
                              89 .setDiscard(DiscardAttributeChecker.ALWAYS, REQUEST_OBJECT_ENCRYPTION_ENC_VALUE)
                              91 .setDiscard(DiscardAttributeChecker.ALWAYS, REQUEST_OBJECT_SIGNING_ALGORITHM)
                              93 .setDiscard(DiscardAttributeChecker.ALWAYS, REQUEST_OBJECT_SIGNING_KEY_ALIAS)
                              95 .setDiscard(DiscardAttributeChecker.ALWAYS, REQUEST_OBJECT_SIGNING_KEY_PASSWORD)
                              97 .setDiscard(DiscardAttributeChecker.ALWAYS, REQUEST_OBJECT_SIGNING_KEYSTORE_FILE)
                              99 .setDiscard(DiscardAttributeChecker.ALWAYS, REQUEST_OBJECT_SIGNING_KEYSTORE_PASSWORD)
                              101 .setDiscard(DiscardAttributeChecker.ALWAYS, REQUEST_OBJECT_SIGNING_KEYSTORE_TYPE)
                              107 .setDiscard(DiscardAttributeChecker.ALWAYS, AUTHENTICATION_REQUEST_FORMAT)
                              109 .setDiscard(DiscardAttributeChecker.ALWAYS, REQUEST_OBJECT_ENCRYPTION_ALG_VALUE)
                              111 .setDiscard(DiscardAttributeChecker.ALWAYS, REQUEST_OBJECT_ENCRYPTION_ENC_VALUE)
                              113 .setDiscard(DiscardAttributeChecker.ALWAYS, REQUEST_OBJECT_SIGNING_ALGORITHM)
                              115 .setDiscard(DiscardAttributeChecker.ALWAYS, REQUEST_OBJECT_SIGNING_KEY_ALIAS)
                              117 .setDiscard(DiscardAttributeChecker.ALWAYS, REQUEST_OBJECT_SIGNING_KEY_PASSWORD)
                              119 .setDiscard(DiscardAttributeChecker.ALWAYS, REQUEST_OBJECT_SIGNING_KEYSTORE_FILE)
                              121 .setDiscard(DiscardAttributeChecker.ALWAYS, REQUEST_OBJECT_SIGNING_KEYSTORE_PASSWORD)
                              123 .setDiscard(DiscardAttributeChecker.ALWAYS, REQUEST_OBJECT_SIGNING_KEYSTORE_TYPE)
                              129 .setDiscard(DiscardAttributeChecker.ALWAYS, AUTHENTICATION_REQUEST_FORMAT)
                              131 .setDiscard(DiscardAttributeChecker.ALWAYS, REQUEST_OBJECT_ENCRYPTION_ALG_VALUE)
                              133 .setDiscard(DiscardAttributeChecker.ALWAYS, REQUEST_OBJECT_ENCRYPTION_ENC_VALUE)
                              135 .setDiscard(DiscardAttributeChecker.ALWAYS, REQUEST_OBJECT_SIGNING_ALGORITHM)
                              137 .setDiscard(DiscardAttributeChecker.ALWAYS, REQUEST_OBJECT_SIGNING_KEY_ALIAS)
                              139 .setDiscard(DiscardAttributeChecker.ALWAYS, REQUEST_OBJECT_SIGNING_KEY_PASSWORD)
                              141 .setDiscard(DiscardAttributeChecker.ALWAYS, REQUEST_OBJECT_SIGNING_KEYSTORE_FILE)
                              143 .setDiscard(DiscardAttributeChecker.ALWAYS, REQUEST_OBJECT_SIGNING_KEYSTORE_PASSWORD)
                              145 .setDiscard(DiscardAttributeChecker.ALWAYS, REQUEST_OBJECT_SIGNING_KEYSTORE_TYPE)
                              151 .setDiscard(DiscardAttributeChecker.ALWAYS, AUTHENTICATION_REQUEST_FORMAT)
                              153 .setDiscard(DiscardAttributeChecker.ALWAYS, REQUEST_OBJECT_ENCRYPTION_ALG_VALUE)
                              155 .setDiscard(DiscardAttributeChecker.ALWAYS, REQUEST_OBJECT_ENCRYPTION_ENC_VALUE)
                              157 .setDiscard(DiscardAttributeChecker.ALWAYS, REQUEST_OBJECT_SIGNING_ALGORITHM)
                              159 .setDiscard(DiscardAttributeChecker.ALWAYS, REQUEST_OBJECT_SIGNING_KEY_ALIAS)
                              161 .setDiscard(DiscardAttributeChecker.ALWAYS, REQUEST_OBJECT_SIGNING_KEY_PASSWORD)
                              163 .setDiscard(DiscardAttributeChecker.ALWAYS, REQUEST_OBJECT_SIGNING_KEYSTORE_FILE)
                              165 .setDiscard(DiscardAttributeChecker.ALWAYS, REQUEST_OBJECT_SIGNING_KEYSTORE_PASSWORD)
                              167 .setDiscard(DiscardAttributeChecker.ALWAYS, REQUEST_OBJECT_SIGNING_KEYSTORE_TYPE)
              wildfly-security  (1 usage found)
                  org.jboss.as.security  (1 usage found)
                      SecurityTransformers  (1 usage found)
                          registerTransformers_1_3_0(SubsystemTransformerRegistration)  (1 usage found)
                              55 .setDiscard(new DiscardAttributeChecker.DiscardAttributeValueChecker(new ModelNode(ORG_PICKETBOX)), MODULE)
      

              bstansbe@redhat.com Brian Stansberry
              bstansbe@redhat.com Brian Stansberry
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved: