Uploaded image for project: 'WildFly Core'
  1. WildFly Core
  2. WFCORE-6442

ModuleSpecification discards dependency information


    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Major Major
    • 22.0.0.Beta1, 22.0.0.Final
    • 20.0.0.Final, 20.0.1.Final, 21.1.0.Final
    • Server
    • None

      The fix for WFCORE-6199 assumes that two ModuleDependency objects with the same ModuleIdentifier are equal, and thus ModuleSpecification discards any provided ModuleDependency if it already has one for the same identifier. But that is not a valid assumption, as different artifacts in a deployment can have their own dependency information. For example an ear's root MANIFEST.mf can have Dependencies: foo while it's lib/alib.jar's MANIFEST.mf can have Dependencies: foo export services metainf. The WFCORE-6199 changes results in discarding important data.

      A possible fix for this is to make ModuleDependency and FilterSpecification override equals and hashcode and check for duplicate ModuleDependencies instead of duplicate identifiers.

            bstansbe@redhat.com Brian Stansberry
            bstansbe@redhat.com Brian Stansberry
            0 Vote for this issue
            3 Start watching this issue