Uploaded image for project: 'Red Hat 3scale API Management'
  1. Red Hat 3scale API Management
  2. THREESCALE-9491

ProxyConfigPromote - improve reporting around successful and failed promotions

XMLWordPrintable

    • 3
    • False
    • None
    • False
    • Not Started
    • Not Started
    • Not Started
    • Not Started
    • Not Started
    • Not Started
    • RHOAM Sprint 44, RHOAM Sprint 45, RHOAM Sprint 46

      3scale operator can promote APIcast configurations with a ProxyConfigPromote  resource. When `spec.deleteCR` is set to `true`, the operator deletes the resource after a successful promotion.

      3scale Operator does not delete the resource when the APIcast configuration is already promoted and no promotion is made.

      Steps to Reproduce:

      1. create a product with a Product custom resource 
      2. create a ProxyConfigPromote with `spec.productCRName`, containing the name of the resource created in step 1, `spec.production: true` and `spec.deleteCR: true`
      3. 3scale operator will promote the APicast configuration to production and delete the ProxyConfigPromote resource
      4. recreate the same ProxyConfigPromote resource as in step 2
      5. 3scale operator does no promotion since no changes were made to the product and does not delete the ProxyConfigPromote resource

      The expectation is that in step 5, 3scale Operator would delete the ProxyConfigPromote resource, even if no promotion were made, because `spec.deleteCR` is set the `true` .

      Update from engineering team:

      The CR should not be removed if the 3scale operator did not perform the promotion, otherwise, we might be misleading customers.

      However, we have also identified an improvement where if no action is taken by the 3scale operator the CR status should reflect it by putting the CR in the failed state instead of leaving the state blank (which might be confusing to customers).I would also like to discuss the removal of deleteCR flag to improve it to something like * either enable audit logging and store all promotion CRs

      • automatically delete all previous promotion CRs and only keep the leader

              Unassigned Unassigned
              rhn-support-cvajjhal Chandrasekhar Vajjhala (Inactive)
              Martin Kudlej Martin Kudlej
              Michal Stokluska Michal Stokluska
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Created:
                Updated:
                Resolved: