-
Task
-
Resolution: Done
-
Major
-
None
-
None
-
3
-
Not Started
-
Not Started
-
Not Started
-
Not Started
-
Not Started
-
Not Started
Implement ActiveRecord level monitoring for the following:
(This has already been implemented in zync: check why operations did not add to dashboard)
- Size of connection pool
- Number of connections in the connection pool
- Number of waiting in the queue of the connection pool
- Time waiting in the queue
Please read the description of the epic this task belongs to.
See for reference: https://github.com/3scale/zync/blob/master/lib/prometheus/active_record.rb#L7
A prrerequisite for the work above is already done (as part of this issue) in https://github.com/3scale/porta/pull/2206 - added stat method, which is missing in Rails 5.0
- is related to
-
-
- Closed
-
- relates to
-
THREESCALE-4743 System grafana dashboard(s) and Prometheus rule definition (system)
-
- Closed
-
[THREESCALE-5698] Implement ActiveRecord level monitoring
srijita_kafka_devexp, this pull request was merged 12 days ago. Can we close this issue? (If so, will you close it for me. 
)
Let's leave it in "in progress" till it's ready for QA. The status "Pull Request Sent" is like "send to /dev/null" for engineering unless a deal has been struck with someone on another team.
Part of the issue (for 2.10 ER1): https://github.com/3scale/porta/pull/2206
We can add it. It does not seem hard to add and we should add a comment saying something like:
- TODO: Remove in 5.1 because it is already implemented
That way, we will be able to tackle all these at once when we upgrade 
Porta uses rails v5.0 and ActiveRecord::Base.connection_pool.stat is implemented in rails v5.1.
See, https://github.com/rails/rails/commit/35b6898f7cb5223e1de4edc1b4539e05dfd83d41
Now, we can opt to wait until Porta is migrated to rails v5.1 or add the stat method explicitly.
cbartlet,Yes, we can close this issue and I certainly will.