-
Task
-
Resolution: Obsolete
-
Major
-
None
-
None
-
0
-
Not Started
-
Not Started
-
Not Started
-
Not Started
-
Not Started
-
Not Started
-
Engineering
-
Invalid Sprint
There is an error when deleting tenants in parallel:
Exception -- {:exception=>{:class=>ArgumentError, :message=>"Missing required parameter: login", :backtrace=>["/home/bender/system_preview/shared/bundle/ruby/2.3.0/gems/activemerchant-1.77.0/lib/active_merchant/billing/gateway.rb:321:in `block in requires!'", "/home/bender/system_preview/shared/bundle/ruby/2.3.0/gems/activemerchant-1.77.0/lib/active_merchant/billing/gateway.rb:314:in `each'", "/home/bender/system_preview/shared/bundle/ruby/2.3.0/gems/activemerchant-1.77.0/lib/active_merchant/billing/gateway.rb:314:in `requires!'", "/home/bender/system_preview/shared/bundle/ruby/2.3.0/gems/activemerchant-1.77.0/lib/active_merchant/billing/gateways/stripe.rb:71:in `initialize'"]}, :parameters=>{:context=>"Job raised exception", :job=>{"class"=>"ActiveJob::QueueAdapters::SidekiqAdapter::JobWrapper", "wrapped"=>"DeletePlainObjectWorker", "queue"=>"default", "args"=>[{"job_class"=>"DeletePlainObjectWorker", "job_id"=>"bdcebe15-2c48-41a2-9d32-e9cace8f17c3", "queue_name"=>"default", "arguments"=>[{"_aj_globalid"=>"gid://system/Account/OBFUSCATEDID"}, ["Hierarchy-Account-OBFUSCATEDID"]], "locale"=>"en"}], "retry"=>true, "jid"=>"f604cefd953a3e991e79186f", "created_at"=>OBFUSCATEDDATE, "enqueued_at"=>1558367154.9197505, "error_message"=>"Missing required parameter: login", "error_class"=>"ArgumentError", "failed_at"=>1558366916.1332533, "retry_count"=>3, "retried_at"=>1558367155.9997318}, :jobstr=>"{\"class\":\"ActiveJob::QueueAdapters::SidekiqAdapter::JobWrapper\",\"wrapped\":\"DeletePlainObjectWorker\",\"queue\":\"default\",\"args\":[{\"job_class\":\"DeletePlainObjectWorker\",\"job_id\":\"bdcebe15-2c48-41a2-9d32-e9cace8f17c3\",\"queue_name\":\"default\",\"arguments\":[{\"_aj_globalid\":\"gid://system/Account/OBFUSCATEDID\"},[\"Hierarchy-Account-OBFUSCATEDID\"]],\"locale\":\"en\"}],\"retry\":true,\"jid\":\"f604cefd953a3e991e79186f\",\"created_at\":1558366914.7207932,\"enqueued_at\":1558367154.9197505,\"error_message\":\"Missing required parameter: login\",\"error_class\":\"ArgumentError\",\"failed_at\":1558366916.1332533,\"retry_count\":2,\"retried_at\":1558367041.2749653}"}}
Explained by Michal:
i finally got the problem with `ArgumentError: Missing required parameter: login`
account has after destroy commit `before_destroy :unstore_credit_card!`
but during that, settings are already gone..
since the account is the last one that is being deleted.. there are not payment/gateway settings..
so the credit card could not be unstored..
Product decision is as follows:
- When a buyer is destroyed but not the tenant, we don't change the behaviour.
- When we destroy the whole tenant, we will try to unstore all the data in the payment gateway of all buyers and the tenant itself, but we will try once... if it doesn't work, we will send an email notifying for which accounts didn't work. And we will also add a message in the UI for deleting tenant saying that it is their responsibility making sure all the info is unstored from the payment gateway.
