Uploaded image for project: 'Knative Serving'
  1. Knative Serving
  2. SRVKS-893

"make test-upstream-e2e-mesh" does not run serving-tests with istio sidecars

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Minor Minor
    • None
    • 1.21.0
    • QA
    • None

      On a fresh cluster, with serverless-operator running

      export KNATIVE_SERVING_HOME=~/go/src/knative.dev/serving
      export DOCKER_REPO_OVERRIDE=quay.io/foobar
      make images
      make dev
      make test-upstream-e2e-mesh

      The actual serving e2e run does not actually use istio sidecars, (notice, pods have 2 containers (test container and a queue-proxy)

      oc get pod -n serving-tests
      NAME                                                              READY   STATUS              RESTARTS      AGE
      autoscale-sustaining-aggregatio-epqvbjad-00001-deployment-4q5dd   2/2     Terminating         0             33s
      autoscale-sustaining-aggregatio-epqvbjad-00001-deployment-8frxl   2/2     Terminating         0             33s
      autoscale-sustaining-aggregatio-epqvbjad-00001-deployment-hg6q6   2/2     Terminating         0             33s
      autoscale-sustaining-aggregatio-epqvbjad-00001-deployment-rx6c8   2/2     Terminating         0             33s
      autoscale-sustaining-aggregatio-fhdcrrok-00001-deployment-6656r   2/2     Running             0             17s
      autoscale-sustaining-aggregatio-fhdcrrok-00001-deployment-drhvv   2/2     Running             0             19s
      autoscale-sustaining-aggregatio-fhdcrrok-00001-deployment-hvdv5   2/2     Running             0             11s
      autoscale-sustaining-aggregatio-fhdcrrok-00001-deployment-lrp5p   2/2     Running             0             31s
      autoscale-sustaining-aggregatio-fhdcrrok-00001-deployment-nj4hc   2/2     Running             0             17s
      autoscale-sustaining-aggregatio-fhdcrrok-00001-deployment-v7sfc   2/2     Running             0             17s
      configuration-get-and-list-ryupjheh-00001-deployment-67dfccpdhw   0/2     Pending             0             0s
      container-exiting-msg-rdgfuesf-00001-deployment-78bbd74477nws4g   1/2     Running             1 (11s ago)   23s
      custom-resources-limits-mpkscnpr-00001-deployment-664989885lqph   2/2     Terminating         1 (4s ago)    19s
      must-env-vars-rmsowvag-00001-deployment-759b445d5f-m2dv2          2/2     Terminating         0             39s
      must-run-as-user-iwqqgjdg-00001-deployment-6d6b66c8b8-6d45q       2/2     Terminating         0             22s
      probe-runtime-http-get-cnoqhhzj-00001-deployment-6f898fc64sxn42   1/2     Running             0             6s
      protocols-default-vefmoihn-00001-deployment-b9c68d66f-ljnbt       2/2     Terminating         0             10s
      protocols-http1-osqsvykw-00001-deployment-794699fbd9-vd89h        2/2     Running             0             8s
      revision-get-and-list-pnthacya-00001-deployment-b4ccd7dc5-4nr56   0/2     ContainerCreating   0             2s
      route-creation-ylysvump-00001-deployment-67c5bb7bf4-pbds4         2/2     Terminating         0             54s
      route-creation-ylysvump-00002-deployment-59b8866598-rtcjr         2/2     Terminating         0             42s
      route-get-and-list-skjbkhcu-00001-deployment-54c6d94b44-wzm6x     2/2     Terminating         0             28s
      secrets-via-env-env-akaqdnja-00001-deployment-67ffc57cc-mnhzp     2/2     Terminating         0             19s
      secrets-via-env-env-from-xoemvaay-00001-deployment-994c9872jkmx   2/2     Terminating         0             17s
      service-create-and-update-jokpswzs-00001-deployment-b5fd4dk5wvj   2/2     Terminating         0             36s
      service-create-and-update-jokpswzs-00002-deployment-c45dbctk9t8   2/2     Terminating         0             25s
      service-create-and-update-jokpswzs-00003-deployment-6b5f4fptjnn   2/2     Terminating         0             16s
      service-create-and-update-jokpswzs-00004-deployment-7bdbfc6nq4j   2/2     Terminating         0             9s
      service-generate-name-rtsrgrxc-7f2g2-00001-deployment-df44xplxr   2/2     Terminating         0             34s
      should-have-files-wyjrtyrx-00001-deployment-7ccd58fcc4-6f57r      2/2     Terminating         0             33s
      should-run-as-user-container-de-isqqsudk-00001-deployment-vlt8g   2/2     Terminating         0             28s
      webhook-65c4bc9c65-jtqtp                                          1/1     Running             0             31m
      working-dir-service-jkysaaen-00001-deployment-595c98d6f6-mfz4q    2/2     Terminating         0             29s 

      It appears that even though the $serving-tests$ namespace is part of the istio-system SMMR, the actual namespace at that time still lacks the "maistra.io/member-of" label, and therefore the pods are not touched by the sidecar-injector.istio.io webhook

      apiVersion: v1
      kind: Namespace
      metadata:
        annotations:
          kubectl.kubernetes.io/last-applied-configuration: |
            {"apiVersion":"v1","kind":"Namespace","metadata":{"annotations":{},"name":"serving-tests"}}
          openshift.io/sa.scc.mcs: s0:c26,c15
          openshift.io/sa.scc.supplemental-groups: 1000680000/10000
          openshift.io/sa.scc.uid-range: 1000680000/10000
        creationTimestamp: "2022-03-18T17:40:24Z"
        labels:
          kubernetes.io/metadata.name: serving-tests
        name: serving-tests
        resourceVersion: "1041733"
        uid: 1d5fc9c9-58c4-4cf4-b7ef-62bf67c73cc6
      spec:
        finalizers:
        - kubernetes
      status:
        phase: Active
      

              rhn-support-knakayam Kenjiro Nakayama (Inactive)
              maschmid@redhat.com Marek Schmidt
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                Resolved: