Uploaded image for project: 'Knative Serving'
  1. Knative Serving
  2. SRVKS-757

Using serving.knative.openshift.io/disableRoute=true leads to invalid URL being shown

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Normal Normal
    • 1.37.0
    • 1.10.0, 1.11.0, 1.12.0, 1.13.0, 1.14.0, 1.15.0
    • None
    • None
    • False
    • False
    • Undefined

      Problem

      When using the serving.knative.openshift.io/disableRoute=true annotation, the knative service displays an invalid URL in .status.url field. The URL that is listed there doesn't resolve to the knative service. The invalid URL is misleading and shouldn't be shown.

      It is also worth to mention that OpenShift Console UI and knative client CLI both display that invalid address in multiple places.

      The Knative Route is also created, and the .status.url field also contains the invalid URL.

      Proposals

      If the serving.knative.openshift.io/disableRoute=true annotation is being used, we either should use a NULL value as the URL for .status.url fields, or used a cluster local URL.

      If we choose to use NULL value in that case, we should make sure that OpenShift UI and kn CLI will handle that NULL properly.

      The best solution would be to detect that user is defined the DomainMapping CR, and if that's the case, use that custom domain in .status.url fields. That can't be done if the user is using kn CLI to create a service, as in the end the CLI will display a text similar to:

      Service 'showcase' created to latest revision 'showcase-00001' is available at URL:
      http://showcase-demo.apps.openshift.example.net
      

      Further improvement would be to detect that the user had created a custom OpenShift TLS Route, and if that's the case, display an HTTPS variant of the custom URL.

              Unassigned Unassigned
              krzysztofsuszynski Chris Suszynski
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated: