Uploaded image for project: 'OpenShift Pipelines'
  1. OpenShift Pipelines
  2. SRVKP-9454

[backport 1.19] After upgrading to Openshift-Pipelines v1.19 PAC dynamic variable `revision` not fetch to newest commit

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Critical Critical
    • Pipelines 1.19.4
    • Pipelines 1.19.0, Pipelines 1.19.1, Pipelines 1.19.2, Pipelines 1.19.3
    • Pipelines as Code
    • None
    • False
    • Hide

      None

      Show
      None
    • False
    • Hide
      With this update, we've reverted a fix which was causing `revision` dynamic variable containing SHA of original commit instead of HEAD merge commit.

      Note to the docs writer: This fix reverts the bugfix for SRVKP-7432, which was originally included in 1.19.0. In the 1.19.4 release notes we need to remove the SRVKP-7432 release notes from the 1.19 bug fixes section and add that bug to the list of known issues in 1.19. Here is a proposed text for the known issue:

      ```
      Due to a regression, the bug fix for SRVKP-6432 was reverted. With the revert, PaC users using Bitbucket Datacenter may see that the PaC `on-paths-changed` annotation does not work correctly for Push events triggered by a Pull Request being merged with the Merge-Commit strategy. To work around this issue, Bitbucket Datacenter users are advised to merge Pull Requests using the Fast Forward, Rebase, or Squash strategies.
      ```
      Show
      With this update, we've reverted a fix which was causing `revision` dynamic variable containing SHA of original commit instead of HEAD merge commit. Note to the docs writer: This fix reverts the bugfix for SRVKP-7432 , which was originally included in 1.19.0. In the 1.19.4 release notes we need to remove the SRVKP-7432 release notes from the 1.19 bug fixes section and add that bug to the list of known issues in 1.19. Here is a proposed text for the known issue: ``` Due to a regression, the bug fix for SRVKP-6432 was reverted. With the revert, PaC users using Bitbucket Datacenter may see that the PaC `on-paths-changed` annotation does not work correctly for Push events triggered by a Pull Request being merged with the Merge-Commit strategy. To work around this issue, Bitbucket Datacenter users are advised to merge Pull Requests using the Fast Forward, Rebase, or Squash strategies. ```
    • Removed Functionality
    • Proposed

      Description of problem:

      The issue occurs when working with more feature branches on Bitbucket Server it's taking the last commit of the branch and not the merged result from the master branch. 

      can not fetch the current changes if the newest commit is a merge commit.

      Do not receive the newest commit in {{ revision }} dynamic variable if the newest commit is a merge commit.

      Prerequisites (if any, like setup, operators/versions): 1.19

      Steps to Reproduce

      • Update to OSP 1.19
      • Use Bitbucket Server/DC for PAC
      • Use Annotations:
          pipelinesascode.tekton.dev/on-event: "[push]"
    pipelinesascode.tekton.dev/on-target-branch: "[refs/tags/*]"
      • upload code, create pull request, and merge commit
      • It triggers a PipelineRun

      Actual results:

      spec:
  params:
    - name: commit-id
      value: "{{revision}}"

      This param {{ revision }} gets last commit of the branch

      Expected results:

      spec:
  params:
    - name: commit-id
      value: "{{revision}}"

      This param {{ revision }} should get newly merged commit{}

      Reproducibility (Always/Intermittent/Only Once): Always

      Acceptance criteria: 

       

      Definition of Done:

      Build Details:

      Additional info (Such as Logs, Screenshots, etc):

       

       *

        1. image-2025-12-04-16-14-27-280.png
          image-2025-12-04-16-14-27-280.png
          46 kB
        2. image-2025-12-04-16-15-06-233.png
          image-2025-12-04-16-15-06-233.png
          21 kB

              cboudjna@redhat.com Chmouel Boudjnah
              rhn-support-anowak Andreas Nowak
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Created:
                Updated:
                Resolved: