-
Task
-
Resolution: Unresolved
-
Undefined
-
None
-
None
-
None
-
sat-endeavour
-
False
-
Satellite Endeavour Refinement
-
None
Goal
Replace the use of Foreman's LineChart in foreman_openscap/app/views/compliance_hosts/show.html.erb. From https://github.com/theforeman/foreman_openscap/blob/872bd17dbb99483e121be193e94b60a2c2495bf5/app/views/compliance_hosts/show.html.erb#L29
<%= react_component('LineChart', host_arf_reports_chart_data(policy.id)) %>
Since this is the only place that is using this wrapper, it should be removed from Foreman, and foreman_openscap should create its own component to use the LineChart. The chart props from pf3 to pf5 are very different and will need to be adjusting.
Acceptance criteria
- LineChart is no longer consumed from Foreman
- The page still shows the reports over time
- Any failing tests are fixed
Open questions
- https://www.patternfly.org/charts/line-chart/ does exist, but this doesn't appear to be available in the @patternfly/react-charts version we're currently using. Can we use this somehow?
- Any impact on Robottelo?
- blocks
-
SAT-38876 Deprecate LineChart wrapper in foreman core
-
- New
-