Description of problem:

ISO repo gets created in 6.16 with empty Download Policy. While it does not create problem in 6.16, when customer upgrades satellite to 6.17, Manifest refresh fails due to empty policy with below error:

~~~

Error message: the server returns an error
HTTP status code: 400
Response body:

~~~

How reproducible:

100%

Is this issue a regression from an earlier version:

In 6.16,  ISO repo gets created without Download Policy (empty),  which seems the cause of this issue. 

Steps to Reproduce:

1.  In satellite 6.16, Sync any ISO repo , for example - Red Hat Enterprise Linux 8 for x86_64 - High Availability ISOs 8

2. Check Download Policy of the repo via GUI and Hammer. GUI does not show "Download Policy" field and hammer shows its empty.

3. Refresh Manifest , it works

4. Upgrade Satellite from 6.16 to 6.17

5. After upgrade, Refresh Manifest again

Actual behavior:
Manifest refresh fails with error :

HTTP status code: 400 , "policy":["\"\" is not a valid choice]

Expected behavior:
Manifest refresh should be successful

Business Impact / Additional info:

It will impact any customer who has synced  ISO repo in 6.16 and upgraded to 6.17

Workaround :

After upgrade to 6.17, Set the Download Policy manually,  manifest refresh works after this.

Suggested Resolution

Address Download policy empty if needed

Add a migration script to the correct the download policy