Uploaded image for project: 'Satellite'
  1. Satellite
  2. SAT-23951

Duplicate repositories in content view versions warning is always active

XMLWordPrintable

    • Sprint 130, Sprint 131, Sprint 132, Sprint 133, Sprint 134, Sprint 135, Sprint 136, Sprint 137, Sprint 138, Sprint 139, Sprint 140, Sprint 141
    • Moderate
    • No

      UI Bug: When publishing a new CCV version, I always see the following warning/info message:

      Duplicate repositories in content view versions
      Repositories common to the selected content view versions will merge, resulting in a composite content view that is a union of all content from each of the content view versions.

      This is displayed whether or not there are any duplicate constituent CV repositories.

      I am pretty sure the bug is this line: https://github.com/Katello/katello/blob/master/webpack/scenes/ContentViews/Publish/CVPublishForm.js#L69

      I am pretty sure it needs to be && instead of ||. Right now `duplicateRepos` is normally an empty list, so `duplicateRepos !== null` is true making the entire disjunction true in the case when the message should not be displayed.

      Since I don't have the dev environment/experience for fixing js bugs, I am hoping someone else can quickly verify the fix and open a PR.

            jira-bugzilla-migration RH Bugzilla Integration
            rhn-engineering-sajha Samir Jha
            Cole Higgins Cole Higgins
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: