Uploaded image for project: 'Satellite'
  1. Satellite
  2. SAT-21325

Bulk Actions not handling kwargs correctly

XMLWordPrintable

    • 0
    • False
    • Moderate
    • None
    • None
    • None
    • None

      Description of problem:
      Consider the following call

      async_task(::Actions::BulkAction, ::Actions::Katello::Repository::Sync, [::Katello::Repository.librar.first], skip_metadata_check: true)

      What ends up happening is that keyword arguments like 'skip_metadata_check' gets converted from symbols to string when BulkAction passes to the Sync.

      Actions like sync expect expect them to be symbols like {:skip_metadata_check => true} but what gets passed to it from BulkActions is

      {'skip_metadata_check' => true}

      making all kwargs passed to it useless.

      Version-Release number of selected component (if applicable):

      How reproducible:

      Steps to Reproduce:
      1.In the console run the following line (assuming you have at least one repo)

      ForemanTasks.sync_task(::Actions::BulkAction, ::Actions::Katello::Repository::Sync, [::Katello::Repository.library.first], skip_metadata_check: true)

      2. Go to https://<sat-fqdn>/foreman_tasks/dynflow
      3. Check the stopped and uncheck the pending and filter the search
      4. You should see tasks Actions::Katello::Repository::Sync followed by Actions::BulkAction
      5. Click show on the sync task
      6. Check the params sent to the Actions::Katello::Repository::Sync
      7. See the value set for skip_metadata_check
      Actual results:
      skip_metadata_check: false

      Expected results:
      skip_metadata_check: true

      Additional info:

      Any bulk action that accepts key word arguments are affected by this.

              aruzicka@redhat.com Adam Ruzicka
              jira-bugzilla-migration RH Bugzilla Integration
              Peter Ondrejka Peter Ondrejka
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved: