Description of problem:
Several cases of false ongoing upgrades have been reported from satellite-maintain when trying to upgrade to the next version.

Version-Release number of selected component (if applicable):
Satellite 6.14

How reproducible:
There are no known reproducing steps. Seems to be very random.

Steps to Reproduce:
1.
2.
3.

Actual results:

• Can't set target version 6.X, 6.Y already in progress

Expected results:
As a last step in a successful upgrade process, this file should be cleared of conflicting content that would cause the update of the rubygem-foreman_maintain package to fail.

Additional info:
I propose that if the last upgrade attempt was unsuccessful that would populate this file with conflicting data to prevent the update of rubygem-foreman_maintain, that the next version of Satellite not be visible to the user. This should also tell the user the reason the last upgrade was reported as a failure, and tell them to run the upgrade again with the current version of Satellite (6.X or 6.X.z).

This would allow customers to understand why they are unable to upgrade to the next version or even see the next version without having to open a case with support and know what KCS to search for to self-solve.

IE:
Currently on Satellite 6.12 and the last upgrade failed due to enabling a sync plan:

1. cat /var/lib/foreman-maintain/data.yml
   —
   upgrade_6.3.z: {}
   :default:
   :upgrade_target_version: '6.12'
   :sync_plans:
   :enabled:

• 1
  :disabled: []
  upgrade_6.4: {}
  upgrade_6.4.z: {}
  upgrade_6.5: {}
  upgrade_6.5.z: {}
  upgrade_6.6: {}
  upgrade_6.6.z: {}
  upgrade_6.7: {}
  upgrade_6.7.z: {}
  upgrade_6.8: {}
  upgrade_6.9: {}
  upgrade_6.9.z: {}
  upgrade_6.10: {}
  upgrade_6.11: {}
  upgrade_6.11.z: {}
  upgrade_6.12:
  :serialized:
  :phase: :post_migrations
  :scenarios:
  :pre_upgrade_checks:
  :label: :satellite_6_12_pre_upgrade_check
  -snip-
• :label: :sync_plans_enable
  :param_values: {}
  :status: :fail
  :output: |-
  Could not update the sync plan:
  ERF28-1357 [ForemanTasks::RecurringLogicCancelledException]: Cannot update a cancelled Recurring Logic.