Uploaded image for project: 'Satellite'
  1. Satellite
  2. SAT-20874

Hammer output message is inconsistent across sub-commands after the entity update

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Minor Minor
    • None
    • 6.10.0
    • Hammer
    • Low
    • None

      Description of problem:
      BZ1868310 introduced a new type of message after the entity is updated and when the user provides no extra arguments.
      New message: "Nothing to update".
      Old message: "<entity_type> updated."
      However, this message is not shown for some Hammer sub-commands and the former message "<entity_type> updated." is printed out. This makes the output messages inconsistent across the sub-commands.
      Affected sub-commands are listed in the reproducer below.

      Version-Release number of selected component (if applicable):
      tfm-rubygem-hammer_cli_foreman_remote_execution-0.2.1-2.el7sat.noarch
      tfm-rubygem-hammer_cli_foreman_bootdisk-0.3.0-2.el7sat.noarch
      tfm-rubygem-hammer_cli_foreman_discovery-1.0.2-2.el7sat.noarch
      tfm-rubygem-hammer_cli_foreman_templates-0.2.0-2.el7sat.noarch
      tfm-rubygem-hammer_cli_foreman_azure_rm-0.2.1-1.el7sat.noarch
      tfm-rubygem-hammer_cli-2.5.1-1.el7sat.noarch
      tfm-rubygem-hammer_cli_katello-1.1.2-1.el7sat.noarch
      tfm-rubygem-hammer_cli_foreman_admin-0.0.10-1.el7sat.noarch
      tfm-rubygem-hammer_cli_foreman_virt_who_configure-0.0.8-1.el7sat.noarch
      tfm-rubygem-hammer_cli_foreman_tasks-0.0.15-2.el7sat.noarch
      tfm-rubygem-hammer_cli_foreman_ansible-0.3.3-2.el7sat.noarch
      tfm-rubygem-hammer_cli_foreman-2.5.1-1.el7sat.noarch
      tfm-rubygem-hammer_cli_foreman_openscap-0.1.12-2.el7sat.noarch

      How reproducible:
      Every time

      Steps to Reproduce (hammer sub-command and the actual command that produces the output):
      activation-key: hammer activation-key update --organization-id 1 --id 1
      ansible (possibly, but I was unable to test it due to BZ1983760)
      content-credentials: hammer content-credentials update --id 1
      domain: hammer domain update --id 1
      filter: hammer filter update --id 336
      host: hammer host update --id 1
      host-collection: hammer host-collection update --id 1
      job-template: hammer job-template update --id 174
      virt-who-config: hammer virt-who-config update --id 1

      Actual results:
      Activation key updated.
      Content Credential updated.
      Domain [my.vms.redhat.com] updated.
      Permission filter for [Config group] updated.
      Host updated.
      Host collection updated.
      Job template updated
      Virt Who configuration [myconfig] updated

      Expected results:
      "Nothing to update" message in all cases.

      Additional info:
      Sub-commands that are not listed in the reproducer section, produce a "Nothing to update" message or explicitly require additional arguments to be provided by the user.

            jira-bugzilla-migration RH Bugzilla Integration
            rhn-engineering-ogajduse Ondrej Gajdusek (Inactive)
            RH Bugzilla Integration RH Bugzilla Integration
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: