Uploaded image for project: 'Satellite'
  1. Satellite
  2. SAT-20211

Delete oprhan content task doesn't remove orphaned remotes in the Capsule

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Normal Normal
    • 6.15.0
    • None
    • None
    • 0
    • False
    • Moderate
    • Sprint 123, Sprint 124, Sprint 125, Sprint 126, Sprint 127, Sprint 128, Sprint 129, Sprint 130, Sprint 131
    • None
    • None
    • None
    • None

      Description of problem:
      If a Capsule has more than 100 Pulp 3 remotes, the delete orphan content task will fail to scan for any orphan Pulp 3 remotes in the Capsule.

      This is because Pulp API by default only returns 100 records. If a Capsule has more than 100 Pulp 3 remotes, then part of the remotes will not be returned by the API call.

      app/services/katello/pulp3/smart_proxy_mirror_repository.rb
      ~~~
      def delete_orphan_remotes
      tasks = []
      smart_proxy_helper = ::Katello::SmartProxyHelper.new(smart_proxy)
      repo_names = smart_proxy_helper.combined_repos_available_to_capsule.map(&:pulp_id)
      acs_remotes = Katello::SmartProxyAlternateContentSource.pluck(:remote_href)
      pulp3_enabled_repo_types.each do |repo_type|
      api = repo_type.pulp3_api(smart_proxy)
      remotes = api.remotes_list <==================== This call will only return 100 remotes

      remotes.each do |remote|
      if !repo_names.include?(remote.name) && !acs_remotes.include?(remote.pulp_href)
      tasks << api.delete_remote(remote.pulp_href)
      end
      end
      end
      tasks
      end
      ~~~

      If you replace the line with the following line then the issue is fixed.
      ~~~
      remotes = api.remotes_list(limit: 10000)
      ~~~

      How reproducible:
      easy

      Steps to Reproduce:
      1. On Satellite, enable and sync some repositories.
      2. Create some content views and some LCEs and then attach the repositories to the CVs.
      3. Add the LCEs to the Capsule.
      4. Make sure the total number of content views' repositories * number of LCEs > 200. It is because the higher the easier to reproduce the issue.
      5. Publish and promote the content views which should trigger auto Capsule sync.
      6. Remove some repositories from the content views, and then publish and promote new versions.
      7. Trigger delete orphan content task
      ~~~
      foreman-rake katello:delete_orphaned_content
      ~~~

      Actual results:
      Either no orphan remotes are deleted or some orphan remotes are not deleted.

      Expected results:
      Delete all orphan remotes in the Capsule.

      Additional infos:
      Leaving the orphan remotes undeleted might cause the Pulp content app to pick the wrong/outdated remote to download contents. It will then fail to download content using the wrong/outdated remote.

              rhn-engineering-sajha Samir Jha
              jira-bugzilla-migration RH Bugzilla Integration
              Sam Bible Sam Bible
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved: