Uploaded image for project: 'Satellite'
  1. Satellite
  2. SAT-15298

hammer repository reclaim-space raises "undefined local variable or method `repositories'" exception

XMLWordPrintable

    • Sprint 113, Sprint 114, Sprint 115, Sprint 116, Sprint 117, Sprint 118, Sprint 119, Sprint 120, Sprint 121, Sprint 122, Sprint 123, Sprint 124, Sprint 125, Sprint 126, Sprint 127, Sprint 128, Sprint 129, Sprint 130, Sprint 131
    • Moderate

      Description of problem:
      hammer repository reclaim-space (for any On Demand repo) fails:

      hammer> repository reclaim-space --id 1 --organization-id 1
      Could not reclaim the repository:
      undefined local variable or method `repositories' for #<Actions::Pulp3::Repository::ReclaimSpace:0x0000564031cede08>
      Did you mean? repository_hrefs
      hammer>

      https://github.com/Katello/katello/blob/master/app/lib/actions/pulp3/repository/reclaim_space.rb#L7 has a left-over from https://github.com/Katello/katello/commit/5b8426e20f4b5812375ed416180f2181ec94312a

      The line should be like:

      repository_hrefs = ::Katello::Pulp3::RepositoryReference.default_cv_repository_hrefs([repo], Organization.current || repo.organization)

      (this does work)

      but I think the 2nd argument should rather be directly "repo.organization", or maybe "repo.organization || Organization.current" to have a fallback - as we should be scoped in the repository organization, no..?

      Version-Release number of selected component (if applicable):
      Sat 6.11
      Sat 6.12
      upcoming 6.13 almost surely as well

      How reproducible:
      100%

      Steps to Reproduce:
      1. Enable and sync a repo with On Demand download policy
      2. try to reclaim space via hammer:

      hammer repository reclaim-space --id REPOID --organization-id ORGID

      Actual results:
      Could not reclaim the repository:
      undefined local variable or method `repositories' for #<Actions::Pulp3::Repository::ReclaimSpace:0x0000564031cede08>
      Did you mean? repository_hrefs

      Expected results:
      It works well

      Additional info:
      The same action via WebUI does work well. "just" hammer fails. (but the bug is in katello)

            rhn-support-wclark William Clark
            jira-bugzilla-migration RH Bugzilla Integration
            Sam Bible Sam Bible
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: