Uploaded image for project: 'RESTEasy'
  1. RESTEasy
  2. RESTEASY-1587

Evaluate different fix for RESTEASY-1205

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Major Major
    • None
    • 3.1.0.Final
    • jaxrs

      This is about evaluating fixing RESTEASY-1025 differently from how it has been fixed in 3.1.0.Final; in particular, see PR #1026: https://github.com/resteasy/Resteasy/pull/1026
      Attached to this jira is the diff file for the PR above.

      Original issue description:

      There is a ByteBuf that is created but never released in ResteasyHttpRequestDecoder. Netty reports this with the following log line:

      LEAK: ByteBuf.release() was not called before it's garbage-collected

      There is a retain called on the HttpRequest content before the newly created Bytebuf is added to an input stream. I'm not entirely sure why this retain is required so I have attached two different pull requests to this issue. One that drops the retain and one that releases the Bytebuf. I would appreciate any information on why the retain is necessary.

        1. 1026.diff
          10 kB
          Alessio Soldano

            Unassigned Unassigned
            rhn-support-asoldano Alessio Soldano
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: