Uploaded image for project: 'RESTEasy'
  1. RESTEasy
  2. RESTEASY-1205

RestEasy-Netty4: ByteBuf leak in ResteasyHttpRequestDecoder

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • Major
    • 3.1.0.Final, 3.0.20.Final
    • 3.0.10.Final, 3.1.0.CR2
    • jaxrs
    • None

    Description

      There is a ByteBuf that is created but never released in ResteasyHttpRequestDecoder. Netty reports this with the following log line:

      LEAK: ByteBuf.release() was not called before it's garbage-collected

      There is a retain called on the HttpRequest content before the newly created Bytebuf is added to an input stream. I'm not entirely sure why this retain is required so I have attached two different pull requests to this issue. One that drops the retain and one that releases the Bytebuf. I would appreciate any information on why the retain is necessary.

      Attachments

        Issue Links

          causes

          Bug - A problem that impairs or prevents the functions of the product. ISPN-6331 Netty buffer leak RESTAsyncIT

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Resolved

          Bug - A problem that impairs or prevents the functions of the product. JDG-708 Netty ByteBuf leak in REST endpoint

          • Blocker - To be worked above all other priorities. This term is chosen when the severity of the issue is very high, has no workaround, or the effort for the change is comparatively low. Issues that may be very publicly visible and could generate significant media attention may also drive a higher priority.
          • Closed

          Bug - A problem that impairs or prevents the functions of the product. ISPN-6880 Netty ByteBuf leak in REST endpoint

          • Critical - To be worked on immediately following BLOCKER issues.
          • Closed
          clones

          Bug - A problem that impairs or prevents the functions of the product. RESTEASY-1095 RestEasy-Netty4: ByteBuf leak in ResteasyHttpRequestDecoder

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Closed
          is cloned by

          Bug - A problem that impairs or prevents the functions of the product. RESTEASY-1587 Evaluate different fix for RESTEASY-1205

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Open
          relates to

          Bug - A problem that impairs or prevents the functions of the product. JBEAP-8608 ByteBuf leak in Resteasy 3.0.19.SP1, blocker for JDG

          • Blocker - To be worked above all other priorities. This term is chosen when the severity of the issue is very high, has no workaround, or the effort for the change is comparatively low. Issues that may be very publicly visible and could generate significant media attention may also drive a higher priority.
          • Closed

          Activity

            People

              gfernand@redhat.com Gustavo Fernandes (Inactive)
              superyizhi YiZhi YiZhi (Inactive)
              Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: