Uploaded image for project: 'Product Technical Learning'
  1. Product Technical Learning
  2. PTL-2191

DO378-51: Ch4 LAB: Grading uses incorrect assumptions

XMLWordPrintable

    • ILT, ROLE, VT
    • en-US (English)

      URL:
      Reporter RHNID:
      Section: -
      Language: en-US (English)||
      Workaround:

      Description: In lab-apps-review script, test_with_flag_disabled searches for a specific state in the features.session-integration toggle, which is broken. The user may have left the application.properties file in an undefined state or set the property to whatever value, so it is incorrect to assume it is currently set to true, or indeed set at all.

      Furthermore, the test assumes there are no spaces around the assignment character, which is broken as well. Valid syntax can include as much whitespace as desired on either side of the equals sign.

      function test_with_flag_disabled {
        ...
      }}{{  sed -i 's/features.session-integration=true/features.session-integration=false/g' src/main/resources/application.properties
        ...
      }

      The above should be rewritten to not assume anything.

      Same for the test_with_flag_enabled function.

            rht-zgutterman Zachary Gutterman
            gregab@p0f.net Grega Bremec
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: