Uploaded image for project: 'Product Technical Learning'
  1. Product Technical Learning
  2. PTL-1480

DO457-76: Additional playbook indentation issues?

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Critical Critical
    • DO457 - RHAE2.5 1 20180720
    • DO457
    • None
    • ILT, ROLE, VT
    • en-US (English)

      URL:
      Reporter RHNID:
      Section: -
      Language: en-US (English)
      Workaround:

      Description: Reported by aeapen@redhat.com for Rajat Agrawal (ragrawal@redhat.com):
      =============================================================================================================================================
       
      Page 124: Module Indented Wrongly
      Page 141: Play name from the playbook writing and executing is mismatched
      Page 164: Indentation of vars and tasks attributes is wrong
      Page 169: Task 1 and Task 2 are having wrong indentations. the module is task 1 is also indented incorrectly.
      Page 188: Spelling of gather_facts has a (G - Capital G), this will fail the playbook. In Task 2, the name attribute doesn't have a value configured to it. In the execution on the right side, it only shows the 1 task execution, the first task of gathering ios facts is not shown, or it is not mentioned that the output has been snipped.
      Page 190: Name of the task in the playbook shown and the name on the execution side is mismatched
      Page 199: In step 1, the command is shown executing in bold font, in the second line, again the same thing is being shown.
      Page 199-200: Step 2 and 3, have the name of the task mismatched
      Page 207: Out of the standard structure of a role, the tests directory is missing from the explanation. 
      Page 213: indentation of module name is wrong and then indentation of role attribute is wrong
      Page 215: Though this example would completely work, but, the way msg option of the debug module is defined in multiple sections, looks non-standardized using best practices
      Page 219: Step 3.2, the output of tree command is wrong, as it shows main.yml, which should be the part of vars directory, is now the part of the ios-cs-ifdescr directory
      Page 273: Step 2.1, compared to other variables, Ansible_ssh_user has a A (Capital A, making it a small (a), would look much standardized)
      Page 286: python-cryptography package comes installed by default, and python-crypto package can be installed optionally.
      Page 289-290: Steps are in wrong sequence in Point 2. 2.3 should be resequenced to 2.2 with the correct language. Same for 3.3, it should be resequenced to 3.2 with the correct language
      Page 335: Additional Step should be added to delete the inventory foobar due to the limitation of the license of the Tower of 10 hosts. If we won't delete this, later in lab 4, requires us to add additional 5 hosts, which spikes the number to 12 which is not possible
      Page 350-351: the option --ask-vault-pass is not required in any of the examples.
      Page 353: Wrong tasks indentation
      Page 358: Step 4.1-4.2, The name of the play is mismatching. The play is originally is running on vyos group, the output is just showing for spine01, either it should also show the output for spine02 or the execution should only be done on spine01. The task also requires, gather_facts: false, as this is network automation and we are anyways gathering facts using vyos_facts module. Similar modifications are required in 4.4 and 4.5 steps as well.
      Page 362: Just above point 4, indentation of both the tasks is wrong.
      Page 367: Option --ask-vault-pass is not required
      Page 377: indentation of commands in both the screenshot is non-standard
      Page 388: In the first screenshot, the example is wrong, there is no module option like hostname. It should be written as the following: 
       
       

      --- 
      - name: configuring hostname
        hosts: ios   
        tasks:
         - ios_command:
             commands:           
               - hostname {{ inventory_hostname }} 
      ...

       
      Also, in the same screenshot, the task is running on leafs group and we are using the ios_config module, which is also wrong. leafs are for vyos group.
       
      Page 389: Both the plays must run on ios group instead of leafs group, as we are using ios_8 modules
      Page 390: The play should run on ios group, instead of leafs.
      Page 404-405: Name of the play is mismatched. as per the output, the task which is pausing play execution for 1 min, is not the part of output.
      Page 411: In task 2, module set_fact and the variable is defined with the wrong indentation
      Page 415: Task 2, set_fact module is setting the fact with the wrong indentation
      Page 441: vars and tasks sections have wrong indentations
      Page 442: backup option does not have any value
      page 510: Indentation of tasks are wrong
       
      =============================================================================================

            ghacker_jira George Hacker (Inactive)
            rajathacker Rajat Agrawal (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: