Uploaded image for project: 'OpenShift Dev Console'
  1. OpenShift Dev Console
  2. ODC-6302

Form / YAML switch makes unnecessary network calls to save latest editor type

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Normal
    • Resolution: Done
    • None
    • openshift-4.9
    • UI
    • False
    • False
    • 0
    • undefined
    • Not Supported
    • Low

    Description

      Description of problem:

      When the user opens a page with a Form / YAML switch, for example the Install Helm chart, Edit Deployment or Edit BuildConfig pages, the pages makes always a patch call to update the user preferences.

      Prerequisites (if any, like setup, operators/versions):

      None

      Steps to Reproduce

      1. Switch to developer perspective > Add > Helm chart
      2. Select a helm chart (for example Dotnet) and press Install Helm Chart
      3. Open the browser network inspector and filter for "user-settings"
      4. Refresh the page

      Actual results:

      You can always the a PATCH call which stores the latest selected editor type (form or yaml)

      Expected results:

      No unnecessary network calls

      Reproducibility (Always/Intermittent/Only Once):

      Always

      Build Details:

      4.9 with ODC-5959 - PR https://github.com/openshift/console/pull/9830

      Additional info:

      1. See review comment https://github.com/openshift/console/pull/9830#pullrequestreview-740648862

      Attachments

        Issue Links

          Activity

            People

              yvakil@redhat.com Yohaan Vakil (Inactive)
              cjerolim Christoph Jerolimov
              Gajanan More Gajanan More (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: