Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-5548

Pipeline is not removed when Deployment/DC/Knative Service or Application is deleted

XMLWordPrintable

    • Low
    • None
    • ODC Sprint 232, ODC Sprint 233
    • 2
    • Rejected
    • False
    • Hide

      None

      Show
      None
    • Hide
      * Previously, the Pipeline connected to `Deployments/DeploymentConfigs/KnativeService` was not deleted if the `Deployments/DeploymentConfigs/KnativeService` resource was deleted. An error was displayed if creating the same resource with Pipeline enabled was attempted. With this fix, the Pipeline and Resources `Deployments/DeploymentConfigs/KnativeService` was deleted. (link:https://issues.redhat.com/browse/OCPBUGS-5548[*OCPBUGS-5548*])
      Show
      * Previously, the Pipeline connected to `Deployments/DeploymentConfigs/KnativeService` was not deleted if the `Deployments/DeploymentConfigs/KnativeService` resource was deleted. An error was displayed if creating the same resource with Pipeline enabled was attempted. With this fix, the Pipeline and Resources `Deployments/DeploymentConfigs/KnativeService` was deleted. (link: https://issues.redhat.com/browse/OCPBUGS-5548 [* OCPBUGS-5548 *])
    • Done

      Description of problem:
      This is a follow-up on https://bugzilla.redhat.com/show_bug.cgi?id=2083087 and https://github.com/openshift/console/pull/12390

      When creating a Deployment, DeploymentConfig, or Knative Service with enabled Pipeline, and then deleting it again with the enabled option "Delete other resources created by console" (only available on 4.13+ with the PR above) the automatically created Pipeline is not deleted.

      When the user tries to create the same resource with a Pipeline again this fails with an error:

      An error occurred
      secrets "nodeinfo-generic-webhook-secret" already exists
      

      Version-Release number of selected component (if applicable):
      4.13

      (we might want to backport this together with https://github.com/openshift/console/pull/12390 and OCPBUGS-5547)

      How reproducible:
      Always

      Steps to Reproduce:

      1. Install OpenShift Pipelines operator (tested with 1.8.2)
      2. Create a new project
      3. Navigate to Add > Import from git and create an application
      4. Case 1: In the topology select the new resource and delete it
      5. Case 2: In the topology select the application group and delete the complete app

      Actual results:
      Case 1: Delete resources:

      1. Deployment (tries it twice!) $name
      2. Service $name
      3. Route $name
      4. ImageStream $name

      Case 2: Delete application:

      1. Deployment (just once) $name
      2. Service $name
      3. Route $name
      4. ImageStream $name

      Expected results:
      Case 1: Delete resource:

      1. Delete Deployment $name should be called just once
      2. (Keep this deletion) Service $name
      3. (Keep this deletion) Route $name
      4. (Keep this deletion) ImageStream $name
      5. Missing deletion of the Tekton Pipeline $name
      6. Missing deletion of the Tekton TriggerTemplate with generated name trigger-template-$name-$random
      7. Missing deletion of the Secret $name-generic-webhook-secret
      8. Missing deletion of the Secret $name-github-webhook-secret

      Case 2: Delete application:

      1. (Keep this deletion) Deployment $name
      2. (Keep this deletion) Service $name
      3. (Keep this deletion) Route $name
      4. (Keep this deletion) ImageStream $name
      5. Missing deletion of the Tekton Pipeline $name
      6. Missing deletion of the Tekton TriggerTemplate with generated name trigger-template-$name-$random
      7. Missing deletion of the Secret $name-generic-webhook-secret
      8. Missing deletion of the Secret $name-github-webhook-secret

      Additional info:

            dsantra12 Debsmita Santra
            cjerolim Christoph Jerolimov
            Sanket Pathak Sanket Pathak
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: