Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-5547

Webhook Secret (1 of 2) is not removed when Knative Service is deleted

    XMLWordPrintable

Details

    • Low
    • ODC Sprint 231
    • Rejected
    • Hide

      None

      Show
      None
    • Hide
      * Previously, the associated webhook `<kn-service-name>-github-webhook-secret` did not delete when deleting a Knative (`kn`) service from the OpenShift Container Platform. With this fix, all the associated webhook secrets are deleted. Now, you can create a Knative (`kn`) service with the same name as the deleted one. (link:https://issues.redhat.com/browse/OCPBUGS-5547[*OCPBUGS-5547*])
      Show
      * Previously, the associated webhook `<kn-service-name>-github-webhook-secret` did not delete when deleting a Knative (`kn`) service from the OpenShift Container Platform. With this fix, all the associated webhook secrets are deleted. Now, you can create a Knative (`kn`) service with the same name as the deleted one. (link: https://issues.redhat.com/browse/OCPBUGS-5547 [* OCPBUGS-5547 *])
    • Bug Fix
    • Done

    Description

      Description of problem:
      This is a follow-up on https://bugzilla.redhat.com/show_bug.cgi?id=2083087 and https://github.com/openshift/console/pull/12390

      When creating a Knative Service and delete it again with enabled option "Delete other resources created by console" (only available on 4.13+ with the PR above) the secret "$name-github-webhook-secret" is not deleted.

      When the user tries to create the same Knative Service again this fails with an error:

      An error occurred
      secrets "nodeinfo-github-webhook-secret" already exists
      

      Version-Release number of selected component (if applicable):
      4.13

      (we might want to backport this together with https://github.com/openshift/console/pull/12390 and OCPBUGS-5548)

      How reproducible:
      Always

      Steps to Reproduce:

      1. Install OpenShift Serverless operator (tested with 1.26.0)
      2. Create a new project
      3. Navigate to Add > Import from git and create an application
      4. In the topology select the Knative Service > "Delete Service" (not Delete App)

      Actual results:
      Deleted resources:

      1. Knative Service (tries it twice!) $name
      2. ImageStream $name
      3. BuildConfig $name
      4. Secret $name-generic-webhook-secret

      Expected results:
      Should also remove this resource

      1. Delete Knative Service should be called just once
      2. Secret $name-github-webhook-secret

      Additional info:
      When delete the whole application all the resources are deleted correctly (and just once)!

      1. Knative Service (just once!) $name
      2. ImageStream $name
      3. BuildConfig $name
      4. Secret $name-generic-webhook-secret
      5. Secret $name-github-webhook-secret

      Attachments

        Issue Links

          Activity

            People

              avik6028 Avik Kundu
              cjerolim Christoph Jerolimov
              Sanket Pathak Sanket Pathak
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: