Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-4698

Some nmstate validations are skipped when NM config is in agent-config.yaml

    XMLWordPrintable

Details

    • Important
    • Proposed
    • Hide

      None

      Show
      None

    Description

      This is a clone of issue OCPBUGS-3987. The following is the description of the original issue:

      Description of problem:

      When the user supplies nmstateConfig in agent-config.yaml invalid configurations may not be detected

      Version-Release number of selected component (if applicable):

      4.12

      How reproducible:

      every time

      Steps to Reproduce:

      1. Create an invalid NM config. In this case an interface was defined with a route but no IP address 
      2. The ISO can be generated with no errors
      3. At run time the invalid was detected by assisted-service, create-cluster-and-infraenv.service logged the error "failed to validate network yaml for host 0, invalid yaml, error:"
       

      Actual results:

      Installation failed

      Expected results:

      Invalid configuration would be detected when ISO is created

      Additional info:

      It looks like the ValidateStaticConfigParams check is ONLY done when the nmstateconfig is provided in nmstateconfig.yaml, not when the file is generated (supplied in agent-config.yaml). https://github.com/openshift/installer/blob/master/pkg/asset/agent/manifests/nmstateconfig.go#L188

       

       

      Attachments

        Issue Links

          Activity

            Public project attachment banner

              context keys: [headless, issue, helper, isAsynchronousRequest, project, action, user]
              current Project key: OCPBUGS

              People

                asegurap1@redhat.com Antoni Segura Puimedon
                openshift-crt-jira-prow OpenShift Prow Bot
                zhenying niu zhenying niu
                Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: