Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-3987

Some nmstate validations are skipped when NM config is in agent-config.yaml

XMLWordPrintable

    • Important
    • Agent Sprint 228
    • 1
    • Rejected
    • False
    • Hide

      None

      Show
      None

      Description of problem:

      When the user supplies nmstateConfig in agent-config.yaml invalid configurations may not be detected

      Version-Release number of selected component (if applicable):

      4.12

      How reproducible:

      every time

      Steps to Reproduce:

      1. Create an invalid NM config. In this case an interface was defined with a route but no IP address 
      2. The ISO can be generated with no errors
      3. At run time the invalid was detected by assisted-service, create-cluster-and-infraenv.service logged the error "failed to validate network yaml for host 0, invalid yaml, error:"
       

      Actual results:

      Installation failed

      Expected results:

      Invalid configuration would be detected when ISO is created

      Additional info:

      It looks like the ValidateStaticConfigParams check is ONLY done when the nmstateconfig is provided in nmstateconfig.yaml, not when the file is generated (supplied in agent-config.yaml). https://github.com/openshift/installer/blob/master/pkg/asset/agent/manifests/nmstateconfig.go#L188

       

       

            bfournie@redhat.com Robert Fournier
            bfournie@redhat.com Robert Fournier
            zhenying niu zhenying niu
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: