Major Description of problem:
oc-mirror will skip the image what tag and digest are empty
stats: shared=4049 unique=72823 size=3.261TiB ratio=0.93
Version-Release number of selected component (if applicable):
How reproducible:
./oc-mirror.rhel8 version
WARNING: This version information is deprecated and will be replaced with the output from --short. Use --output=yaml|json to get the full version.
Client Version: version.Info{Major:"", Minor:"", GitVersion:"4.18.0-202411090338.p0.g0a7dbc9.assembly.stream.el9-0a7dbc9", GitCommit:"0a7dbc90746a26ddff3bd438c7db16214dcda1c3", GitTreeState:"clean", BuildDate:"2024-11-09T08:33:46Z", GoVersion:"go1.22.7 (Red Hat 1.22.7-1.module+el8.10.0+22325+dc584f75) X:strictfipsruntime", Compiler:"gc", Platform:"linux/amd64"}
Steps to Reproduce:
1. Run oc-mirror v2 with following imagesetconfig:
cat config.yaml
kind: ImageSetConfiguration
apiVersion: mirror.openshift.io/v2alpha1
mirror:
operators:
- catalog: registry.redhat.io/redhat/redhat-operator-index:v4.15
`./oc-mirror.rhel8 -c config.yaml --workspace file://m2m --v2 docker://localhost:5000 --dest-tls-verify=false`
Actual results:
see logs :
./oc-mirror.rhel8 -c config.yaml --workspace file://m2m --v2 docker://localhost:5000 --dest-tls-verify=false2024/11/13 00:34:34 [WARN] : ⚠️ --v2 flag identified, flow redirected to the oc-mirror v2 version. This is Tech Preview, it is still under development and it is not production ready.
2024/11/13 00:34:34 [INFO] : 👋 Hello, welcome to oc-mirror
2024/11/13 00:34:34 [INFO] : ⚙️ setting up the environment for you...
2024/11/13 00:34:34 [INFO] : 🔀 workflow mode: mirrorToMirror
2024/11/13 00:34:34 [INFO] : 🕵️ going to discover the necessary images...
2024/11/13 00:34:34 [INFO] : 🔍 collecting release images...
2024/11/13 00:34:34 [INFO] : 🔍 collecting operator images...
2024/11/13 00:35:17 [WARN] : error parsing image registry.redhat.io/openshift4/ose-kube-rbac-proxy-rhel9 : registry.redhat.io/openshift4/ose-kube-rbac-proxy-rhel9 unable to parse image correctly : tag and digest are empty
2024/11/13 00:35:17 [WARN] : registry.redhat.io/openshift4/ose-kube-rbac-proxy-rhel9 unable to parse image correctly : tag and digest are empty : SKIPPING
Expected results:
should not skip the image
Additional info:
`oc image info` could check the image , so oc-mirror should mirror it too oc image info registry.redhat.io/openshift4/ose-kube-rbac-proxy-rhel9 error: the image is a manifest list and contains multiple images - use --filter-by-os to select from: OS DIGEST linux/amd64 sha256:a933ae97f04189ee1990d9bdb9ea3b549ab59001acd7047f7de3451f6f91d4af linux/arm64 sha256:e099f83e6db7911c0253fc61ce404b7c9c3acf953d48f2867a9a81f8ac5a7bfa linux/ppc64le sha256:7225fc1339ef9f11be9f9378cbe72e9fa5005e826a9a4d1be8fbb662015d3993 linux/s390x sha256:4a33f942aed400a259ada10c51304fd4fd2a6326aee342c72e72fa9618797cf9
