Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-33635

[release-4.14] Masthead logo no longer restricted to a max-height of 60px

XMLWordPrintable

    • No
    • False
    • Hide

      None

      Show
      None
    • Hide
      * Previously, a logo in the masthead element of the {product-title} web console could grow beyond 60 pixels in height. This caused the masthead to increase in height. With this release, the masthead logo is constrained to a `max-height` of 60 pixels. (link:https://issues.redhat.com/browse/OCPBUGS-33635[*OCPBUGS-33635*])
      Show
      * Previously, a logo in the masthead element of the {product-title} web console could grow beyond 60 pixels in height. This caused the masthead to increase in height. With this release, the masthead logo is constrained to a `max-height` of 60 pixels. (link: https://issues.redhat.com/browse/OCPBUGS-33635 [* OCPBUGS-33635 *])
    • Bug Fix
    • Done

      This is a clone of issue OCPBUGS-33523. The following is the description of the original issue:
      —
      With the change from PatternFly's `PageHeader` to `Masthead`, there is no longer a max-height of 60px restricting the size of the masthead logo.  As a result, logos that are larger than 60px high display at their native size and cause the masthead to get taller (see https://drive.google.com/file/d/11enMtMU1cfzXQqRfd0eTdsKFkBVPWoFc/view?usp=sharing).  This went unnoticed in the change because OpenShift and OKD logos are sized appropriately for the masthead and do not need the restriction.  Further, the docs state a custom logo "is constrained to a max-width of 200px and a max-height` of 68px.", which is a separate bug that needs to be addressed (should read "is constrained to a max-height of 60px").

              rhn-engineering-rhamilto Robb Hamilton
              openshift-crt-jira-prow OpenShift Prow Bot
              Yanping Zhang Yanping Zhang
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Created:
                Updated:
                Resolved: