Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-33523

Masthead logo no longer restricted to a max-height of 60px

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done-Errata
    • Icon: Normal Normal
    • 4.16.0
    • 4.13, 4.14, 4.15, 4.16.0
    • Management Console
    • None
    • No
    • False
    • Hide

      None

      Show
      None
    • Hide
      * Previously, the masthead logo was not restricted to a max-height of 60px, and logos larger that 60px making the masthead size too large. With this update, the masthead logo is restricted to a max-height of 60px. (link:https://issues.redhat.com/browse/OCPBUGS-33523[*OCPBUGS-33523*])
      Show
      * Previously, the masthead logo was not restricted to a max-height of 60px, and logos larger that 60px making the masthead size too large. With this update, the masthead logo is restricted to a max-height of 60px. (link: https://issues.redhat.com/browse/OCPBUGS-33523 [* OCPBUGS-33523 *])
    • Bug Fix
    • Done

      With the change from PatternFly's `PageHeader` to `Masthead`, there is no longer a max-height of 60px restricting the size of the masthead logo.  As a result, logos that are larger than 60px high display at their native size and cause the masthead to get taller (see https://drive.google.com/file/d/11enMtMU1cfzXQqRfd0eTdsKFkBVPWoFc/view?usp=sharing).  This went unnoticed in the change because OpenShift and OKD logos are sized appropriately for the masthead and do not need the restriction.  Further, the docs state a custom logo "is constrained to a max-width of 200px and a max-height` of 68px.", which is a separate bug that needs to be addressed (should read "is constrained to a max-height of 60px").

            rhn-engineering-rhamilto Robb Hamilton
            rhn-support-mrobson Matt Robson
            Yanping Zhang Yanping Zhang
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved: