Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-20488

[4.14] Avoid caching etcdctl on cluster-backup.sh

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done-Errata
    • Normal
    • 4.13.z
    • 4.13, 4.12, 4.11, 4.14, 4.15
    • Etcd
    • None
    • Low
    • No
    • Rejected
    • False
    • Hide

      None

      Show
      None
    • Hide
      The `etcdctl` binary was cached on the local machine indefinitely, which made updates impossible. The binary is now pulled on every invocation of the `cluster-backup.sh` script. (link:https://issues.redhat.com/browse/OCPBUGS-20488[*OCPBUGS-20488*])
      Show
      The `etcdctl` binary was cached on the local machine indefinitely, which made updates impossible. The binary is now pulled on every invocation of the `cluster-backup.sh` script. (link: https://issues.redhat.com/browse/OCPBUGS-20488 [* OCPBUGS-20488 *])
    • Bug Fix
    • Done

    Description

      This is a clone of issue OCPBUGS-19499. The following is the description of the original issue:

      This is a clone of issue OCPBUGS-19052. The following is the description of the original issue:

      Description of problem:

      With OCPBUGS-18274 we had to update the etcdctl binary. Unfortunately the script does not attempt to update the binary if it's found in the path already:
      
      https://github.com/openshift/cluster-etcd-operator/blob/master/bindata/etcd/etcd-common-tools#L16-L24
      
      This causes confusion as the binary might not be the latest that we're shipping with etcd.
      
      Pulling the binary shouldn't be a big deal, etcd is running locally anyway and the local image should be cached already just fine. We should always replace the binary

      Version-Release number of selected component (if applicable):

      any currently supported release

      How reproducible:

      always

      Steps to Reproduce:

      1. run cluster-backup.sh to download the binary
      2. update the etcd image (take a different version or so)
      3. run cluster-backup.sh again 

      Actual results:

      cluster-backup.sh will simply print "etcdctl is already installed"

      Expected results:

      etcdctl should always be pulled

      Additional info:

       

      Attachments

        Issue Links

          Activity

            People

              dwest@redhat.com Dean West
              openshift-crt-jira-prow OpenShift Prow Bot
              ge liu ge liu
              Laura Hinson Laura Hinson
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: