Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-19499

[4.14] Avoid caching etcdctl on cluster-backup.sh

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done-Errata
    • Icon: Normal Normal
    • 4.14.0
    • 4.13, 4.12, 4.11, 4.14, 4.15
    • Etcd
    • None
    • Low
    • No
    • 1
    • ETCD Sprint 242, ETCD Sprint 243
    • 2
    • False
    • Hide

      None

      Show
      None
    • Hide
      Previously, the `etcdctl` binary was cached on the local machine indefinitely, making updates to the binary impossible. The binary is now properly updated on every invocation of the `cluster-backup.sh` script. (link:https://issues.redhat.com/browse/OCPBUGS-19499[*OCPBUGS-19499*])
      Show
      Previously, the `etcdctl` binary was cached on the local machine indefinitely, making updates to the binary impossible. The binary is now properly updated on every invocation of the `cluster-backup.sh` script. (link: https://issues.redhat.com/browse/OCPBUGS-19499 [* OCPBUGS-19499 *])
    • Bug Fix
    • Done

      This is a clone of issue OCPBUGS-19052. The following is the description of the original issue:
      —
      Description of problem:

      With OCPBUGS-18274 we had to update the etcdctl binary. Unfortunately the script does not attempt to update the binary if it's found in the path already:

https://github.com/openshift/cluster-etcd-operator/blob/master/bindata/etcd/etcd-common-tools#L16-L24

This causes confusion as the binary might not be the latest that we're shipping with etcd.

Pulling the binary shouldn't be a big deal, etcd is running locally anyway and the local image should be cached already just fine. We should always replace the binary

      Version-Release number of selected component (if applicable):

      any currently supported release

      How reproducible:

      always

      Steps to Reproduce:

      1. run cluster-backup.sh to download the binary
2. update the etcd image (take a different version or so)
3. run cluster-backup.sh again

      Actual results:

      cluster-backup.sh will simply print "etcdctl is already installed"

      Expected results:

      etcdctl should always be pulled

      Additional info:

       

            [OCPBUGS-19499] [4.14] Avoid caching etcdctl on cluster-backup.sh

            Errata Tool added a comment -

            Since the problem described in this issue should be resolved in a recent advisory, it has been closed.

            For information on the advisory (Important: OpenShift Container Platform 4.14.0 bug fix and security update), and where to find the updated files, follow the link below.

            If the solution does not work for you, open a new bug report.
            https://access.redhat.com/errata/RHSA-2023:5006

            Errata Tool added a comment - Since the problem described in this issue should be resolved in a recent advisory, it has been closed. For information on the advisory (Important: OpenShift Container Platform 4.14.0 bug fix and security update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2023:5006

            OpenShift Jira Bot added a comment -

            Hi tjungblu@redhat.com,

            Bugs should not be moved to Verified without first providing a Release Note Type("Bug Fix" or "No Doc Update") and for type "Bug Fix" the Release Note Text must also be provided. Please populate the necessary fields before moving the Bug to Verified.

            OpenShift Jira Bot added a comment - Hi tjungblu@redhat.com , Bugs should not be moved to Verified without first providing a Release Note Type("Bug Fix" or "No Doc Update") and for type "Bug Fix" the Release Note Text must also be provided. Please populate the necessary fields before moving the Bug to Verified.

              tjungblu@redhat.com Thomas Jungblut
              openshift-crt-jira-prow OpenShift Prow Bot
              Ge Liu Ge Liu
              Kevin Owen Kevin Owen
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Created:
                Updated:
                Resolved: