Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-15743

Hypershift NodePool AllMachinesReady and AllNodesHealthy should have message conditions ordered

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done-Errata
    • Icon: Major Major
    • None
    • 4.12
    • HyperShift
    • No
    • Rejected
    • False
    • Hide

      None

      Show
      None

      This is a clone of issue OCPBUGS-15723. The following is the description of the original issue:

      Description of problem:

      
      NodePool conditions AllMachinesReady and AllNodesHealthy are used by Cluster Service to detect problems on customer nodes.
      
      Everytime a NodePool is updated, it triggers an update in a ManifestWork that is being processed by CS to build a user message about why a specific machinepool/nodepool is not healthy.
      
      The lack of a sorted message when there are more than one machines creates a bug that the NodePool is updated multiple time, when the state is the same.
      
      For example, CS may capture scenarios like this and consider them like the change is the same.
      
      Machine rosa-vws58-workshop-69b55d58b-mq44p: UnhealthyNode
      Machine rosa-vws58-workshop-69b55d58b-97n47: UnhealthyNode ,
      Machine rosa-vws58-workshop-69b55d58b-mq44p: NodeConditionsFailed
      Machine rosa-vws58-workshop-69b55d58b-97n47: Deleting ,
      
      Machine rosa-vws58-workshop-69b55d58b-97n47: UnhealthyNode
      Machine rosa-vws58-workshop-69b55d58b-mq44p: UnhealthyNode ,
      Machine rosa-vws58-workshop-69b55d58b-97n47: Deleting
      Machine rosa-vws58-workshop-69b55d58b-mq44p: NodeConditionsFailed ,
      
      Machine rosa-vws58-workshop-69b55d58b-mq44p: UnhealthyNode
      Machine rosa-vws58-workshop-69b55d58b-97n47: UnhealthyNode ,
      Machine rosa-vws58-workshop-69b55d58b-mq44p: NodeConditionsFailed
      Machine rosa-vws58-workshop-69b55d58b-97n47: Deleting ,
      

      Expected results:

      
      The HyperShift Operator should sort the messages where multiple machines/nodes are invovled:
      
      https://github.com/openshift/hypershift/blob/86af31a5a5cdee3da0d7f65f3bd550f4ec9cac55/hypershift-operator/controllers/nodepool/nodepool_controller.go#L2509
      
      

            agarcial@redhat.com Alberto Garcia Lamela
            openshift-crt-jira-prow OpenShift Prow Bot
            Jie Zhao Jie Zhao
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: