-
Task
-
Resolution: Done
-
Normal
-
None
-
None
-
3
-
False
-
-
False
-
-
-
3
-
OCMUI Core Sprint 273, OCMUI Core Sprint 274, OCMUI Core Sprint 275, OCMUI Core Sprint 276, OCMUI Core Sprint 277
I decided to let Formik context hold the entire MachineType object instead of just the id since it would be better to have the entire object if needed to use it instead of searching for it from the list of MachineTypes. This would save computing time in filtering searching for that specific MachineType from the list, using it’s id every time we need to use it, like in our case on the newly created component: WindowsLicenseIncludedCheckboxField.
That way we can access the selected MachineType on every component related to the EditMachinePoolModal (since it would be defined on this modal), which would ease the implementation of the WindowsLI feature, since the new field is dependent on the selected MachineType.
This is a change which will be done before implementing the WindowsLI feature (OCMUI-2904) but will be included in the same PR to save time
- relates to
-
OCMUI-2904 [ROSA-HCP] Windows LI Phase 1: Add UI Implementation
-
- Closed
-
- links to