Uploaded image for project: 'OCMUI - OpenShift Cluster Manager UI'
  1. OCMUI - OpenShift Cluster Manager UI
  2. OCMUI-2904

[ROSA-HCP] Windows LI Phase 1: Add UI Implementation

    • Product / Portfolio Work
    • 8
    • False
    • False
    • 8
    • OCMUI Core Sprint 268, OCMUI Core Sprint 269, OCMUI Core Sprint 272, OCMUI Core Sprint 273, OCMUI Core Sprint 274, OCMUI Core Sprint 275, OCMUI Core Sprint 276, OCMUI Core Sprint 277

      Day 2

      On ClusterDetails page of a ready (ROSA HCP) cluster, go to 'Machine pools' Tab (You need to own the cluster or to have permissions to add new Machine pools in order to be able to proceed to the next steps)

      Click on 'Add machine pool' button which should open a modal entitled "Add machine pool"

      Under 'Compute node instance type' section, we can find different groups of node instance types. Some of the instance types are 'WindowsLICompatible' (See explanation on the 'User Story' section and the attached documents found on the linked Epic for more information)

      • On the "Add machine pool" modal, under the 'Compute node instance type' section below the Select, add a new checkbox with the description:
        "Enable machine pool for Windows License Included"
        (See screenshot 1)

                 This checkbox should have the following functionality:

        • In case the selected MachineType is 'WindowsLICompatible' according to the value which the backend provides (See {**} on the Important Notes section on the Epic for more details) -> the checkbox should be selectable (enabled).
        • In case it isn't -> the checkbox should be disabled
        • When a user has selected a 'WindowsLICompatible' instance type, has checked the checkbox, and then selected a different 'WindowsLICompatible' instance type -> the checkbox should remain checked
        • When a user has selected a 'WindowsLICompatible' instance type, checked the checkbox, and then selected a non 'WindowsLICompatible' instance type -> the checkbox should be un-checked and disabled

                 When enabled, the machine pool is AWS License Included for Windows with associated fees.
                 """
                 The two links leading to documentation:

      • In case a user hovers over the disabled checkbox, a Tooltip should pop out containing the following description:
        "This instance type is not Windows License Included compatible." (Not as the screenshot determines -> This was decided on a thread on the PR)
        The same Popover should still be present next to it.
        (See screenshot 2)
      • On the "Edit machine pool" modal, add text specifying if the currently edited machine pool has Windows LI enabled.
        "This machine pool is Windows LI enabled." with a Popover containing the same description mentioned above.
        (See screenshot 3)
      • Create a Feature Flag: "ocmui-windows-license-included"

      Important to mention: 

      • All added components should be hidden under a related Feature Flag: "ocmui-windows-license-included" -> Phase 1
      • Once the backend team will implement the necessary API queries, we'll add the values from the backend -> Phase 2
      • Once the docs team finishes Red Hat's official documentation, the article link will be switched with the new link -> Phase 2
      • Once everything is ready, the feature flag will be removed -> Phase 3
      • For more information, have a look at the linked Epic

        1. 1. Add machine pool modal - Checkbox + Popover.png
          198 kB
          Lior Keren
        2. 2. Disabled checkbox + Tooltip.png
          189 kB
          Lior Keren
        3. 3. Edit machine pool modal suggestion - with Popover.png
          178 kB
          Lior Keren
        4. mp.png
          76 kB
          David Taylor

              lkeren-ocm Lior Keren
              lkeren-ocm Lior Keren
              Denis Ragan Denis Ragan
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                Resolved: