Description of problem:
Missing validation for the field "Max node total" field during following circumstances.
- The "max node total" value is -ve
- The "max node total" value is less than minimum required node count per cluster.
This happens from both day 1 and day 2 side. For day 1 the wizard throws a backend error at least for day 2 , no indication the operation failed in UI and it leaves user in clueless situations.
See the recordings.Screen Recording 2024-11-21 at 12.11.10 PM.mov
How reproducible:
always
Steps to Reproduce:
- Open OCM UI staging
- Open a ROSA classic wizard flow.
- Fill all required fields from each wizard steps and reach to "Default machine pool" step.
- Check " Enable autoscaling"
- Click "Edit cluster autoscaling settings".
- Change the max node total value to a -ve number.
- See the validation.
- Change the max node total value less than minimum node count requirement for the cluster autoscaling.
- See the validation.
- Close the wizard.
- Go to cluster list and open a ready cluster.
- Go to machine pool tab and click "Edit cluster autoscaling settings".
- Repeat the step 6 and click "Save" button.
- See the behavior
- Repeat the step 8 and click "Save" button.
- See the behavior
Actual results:
At step 7 & 9, there is no validation error thrown in OCM UI against max node total. However; the wizard submission blocked with backend error.
At step 14, As part of day 2 action, there is no validation error thrown in OCM UI against max node total.
Both Step 14 and 15, The save action seems to indicate that data is saved successfully as there is no error in UI. But the backend request to update the autoscaling settings eventually failed.
Expected results:
To avoid all above situation, introduce the validation for max node count field for below circumstances
1. At step 7 & 14, Introduce the validation error in case of -ve value.
2. At step 9, Probably this is difficult for now and same complication discussed in OCMUI-2646 . We could ignore this behavior now.
3. At step 14 & 15 (day 2 actions), Throw an error in OCM UI while saving invalid or unsupported max node count total definition (i.e. when the backend calls to update the autoscaling definition fails).