-
Sub-task
-
Resolution: Unresolved
-
Undefined
-
None
-
None
-
None
-
4
-
False
-
-
False
-
ToDo
-
-
-
0
-
0.000
-
Very Likely
-
0
-
None
-
Unset
-
Unknown
Description of problem:
Currently DPA allows us creating multiple BackupStorageLocation with default value set as true. If BSL name is "default" then we must have default flag set to true to avoid further issues. For more details please refer the slack thread.
https://redhat-internal.slack.com/archives/C0144ECKUJ0/p1699358672496249
Version-Release number of selected component (if applicable):
OADP 1.3.0
How reproducible:
Always
Steps to Reproduce:
1. Create a DPA with multiple BSL location set as default.
$ oc get dpa ts-dpa -o yaml apiVersion: oadp.openshift.io/v1alpha1 kind: DataProtectionApplication metadata: creationTimestamp: "2023-11-07T06:52:46Z" generation: 6 name: ts-dpa namespace: openshift-adp resourceVersion: "115621" uid: de65e475-24da-4152-819e-367099494ea6 spec: backupLocations: - velero: config: insecureSkipTLSVerify: "true" profile: noobaa region: noobaa s3ForcePathStyle: "true" s3Url: http://s3-openshift-storage.apps.oadp-61240.qe.devcluster.openshift.com credential: key: cloud name: cloud-credentials default: true objectStorage: bucket: oadpbucket245076 prefix: velero provider: aws - velero: config: insecureSkipTLSVerify: "true" profile: noobaa region: noobaa s3ForcePathStyle: "true" s3Url: http://s3-openshift-storage.apps.oadp-61240.qe.devcluster.openshift.com credential: key: cloud name: cloud-credentials default: true objectStorage: bucket: oadpbucket245076 prefix: velero provider: aws configuration: nodeAgent: enable: true podConfig: resourceAllocations: limits: cpu: 100m memory: 50Mi requests: cpu: 50m memory: 10Mi uploaderType: kopia velero: defaultPlugins: - openshift - aws - csi
Actual results:
Multiple BackupStorageLocation can be set as default. if the backupLocation name starts with default and default-backup-location flag set as false then backup_storage_location controller tries to add default: true flag and oadp controller removes that flag continuously which generates a huge no. of logs.
Expected results:
DPA should prevent creating multple default BSL. if backupLocation name is default then it must be the default-backup-location.
Additional info:
