Uploaded image for project: 'OpenShift API for Data Protection'
  1. OpenShift API for Data Protection
  2. OADP-3329

DPA validation to ensure only one default, and if named "default" that must be default

    XMLWordPrintable

Details

    • False
    • Hide

      None

      Show
      None
    • False
    • oadp-operator-bundle-container-1.3.0-152
    • ToDo
    • No
    • 0
    • 0
    • Very Likely
    • 0
    • None
    • Unset
    • Unknown

    Description

      Description of problem:

      Currently DPA allows us creating multiple BackupStorageLocation with default value set as true. If BSL name is "default" then we must have default flag set to true to avoid further issues. For more details please refer the slack thread. 
      https://redhat-internal.slack.com/archives/C0144ECKUJ0/p1699358672496249

       

      Version-Release number of selected component (if applicable):

      OADP 1.3.0

       

      How reproducible:
      Always

       

      Steps to Reproduce:

      1.  Create a DPA with multiple BSL location set as default.

      $ oc get dpa ts-dpa -o yaml
apiVersion: oadp.openshift.io/v1alpha1
kind: DataProtectionApplication
metadata:
  creationTimestamp: "2023-11-07T06:52:46Z"
  generation: 6
  name: ts-dpa
  namespace: openshift-adp
  resourceVersion: "115621"
  uid: de65e475-24da-4152-819e-367099494ea6
spec:
  backupLocations:
  - velero:
      config:
        insecureSkipTLSVerify: "true"
        profile: noobaa
        region: noobaa
        s3ForcePathStyle: "true"
        s3Url: http://s3-openshift-storage.apps.oadp-61240.qe.devcluster.openshift.com
      credential:
        key: cloud
        name: cloud-credentials
      default: true
      objectStorage:
        bucket: oadpbucket245076
        prefix: velero
      provider: aws
  - velero:
      config:
        insecureSkipTLSVerify: "true"
        profile: noobaa
        region: noobaa
        s3ForcePathStyle: "true"
        s3Url: http://s3-openshift-storage.apps.oadp-61240.qe.devcluster.openshift.com
      credential:
        key: cloud
        name: cloud-credentials
      default: true
      objectStorage:
        bucket: oadpbucket245076
        prefix: velero
      provider: aws
  configuration:
    nodeAgent:
      enable: true
      podConfig:
        resourceAllocations:
          limits:
            cpu: 100m
            memory: 50Mi
          requests:
            cpu: 50m
            memory: 10Mi
      uploaderType: kopia
    velero:
      defaultPlugins:
      - openshift
      - aws
      - csi

      Actual results:

      Multiple BackupStorageLocation can be set as default.  if the backupLocation name starts with default and default-backup-location flag set as false then backup_storage_location controller tries to add default: true flag and oadp controller removes that flag continuously which generates a huge no. of logs. 

       

      Expected results:

      DPA should prevent creating multple default BSL.  if backupLocation name is default then it must be the default-backup-location.

       

      Additional info:

      Attachments

        Issue Links

          clones

          Bug - A problem that impairs or prevents the functions of the product. OADP-3054 DPA validation to ensure only one default, and if named "default" that must be default

          • Blocker - To be worked above all other priorities. This term is chosen when the severity of the issue is very high, has no workaround, or the effort for the change is comparatively low. Issues that may be very publicly visible and could generate significant media attention may also drive a higher priority.
          • Closed
          links to

          GitHub openshift/oadp-operator#1220: OADP-3054: BSL default configuration validation

          Web Link RHSA-2023:112677 OpenShift API for Data Protection (OADP) 1.3.0 release advisory

          mentioned on

          GitLab Merge request - Updated US source to: 66d0b27 OADP-3054: BSL default configuration validation (#1220)

          Activity

            People

              wnstb Wes Hayutin
              rhn-support-prajoshi Prasad Joshi
              Prasad Joshi Prasad Joshi
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated: